-
Notifications
You must be signed in to change notification settings - Fork 316
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Restore error event for invalid workerType
This uses the "invalid" state of <link workertype> introduced in whatwg/html#2740
- Loading branch information
1 parent
fcf2835
commit 18e52c5
Showing
1 changed file
with
1 addition
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 comments
on commit 18e52c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we decided it should be ignored (i.e. no service worker should be installed), not fire an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
States are marked up as italics, not strings.
Ah yes, fixed
I thought we decided it should be ignored (i.e. no service worker should be installed), not fire an error.
Oofs, OK—fixed now
States are marked up as italics, not strings.