Tweak <link>.workerType reflection #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking "do not merge yet" per w3c/ServiceWorker#1110 (comment) as I should update this to also add an invalid state. |
domenic
added
do not merge yet
domenic
removed
the
do not merge yet
|
Updated and ready for a new round of review |
9c7da49 removed the idea of using enumerations in the IDL to case-sensitively reflect properties, but forgot to switch <link>'s workerType attribute to DOMString. This fixes that. Additionally, this introduces the invalid state as the invalid value default, so that service workers' processing model can ignore invalid values instead of treating them as classic scripts (similar to <script>'s type="" attribute).
sideshowbarker
approved these changes
Jun 10, 2017
sideshowbarker
added a commit
to w3c/ServiceWorker
that referenced
this pull request
Jun 10, 2017
This uses the "invalid" state of <link workertype> introduced in whatwg/html#2740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9c7da49 removed the idea of using
enumerations in the IDL to case-sensitively reflect properties, but
forgot to switch
<link>'s workerType attribute to DOMString.Tests: web-platform-tests/wpt#6164 #