-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of mock sensor type #54
Conversation
Fixes part of w3c/sensors#378
@anssiko and all, PTAL. Thanks! |
It's AmbientLightSensor class has an associated mock sensor type
Seems good to me. @reillyeon please take a look too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate we can't extend an enum from a separate specification.
Yes, partial enum is still not a thing. The topic been discussed in this group earlier w3c/sensors#22 (comment) |
@anssiko, @reillyeon, many thanks for your review! |
@Honry The Please create a PR to update this spec and also update the other PRs for other concrete specs accordingly. |
@Honry since the other PRs did not have any enum linking errors, you probably updated the anchor data between the builds? |
Oh, I find the root cause now, I did't update the anchor data between the builds, I will do that for all PRs. |
Fixes part of w3c/sensors#378
Preview | Diff