Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of mock sensor type #54

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Jan 25, 2019

Fixes part of w3c/sensors#378


Preview | Diff

@Honry
Copy link
Contributor Author

Honry commented Jan 25, 2019

@anssiko and all, PTAL. Thanks!

It's AmbientLightSensor class has an associated mock sensor type
@anssiko
Copy link
Member

anssiko commented Jan 25, 2019

Seems good to me.

@reillyeon please take a look too.

Copy link
Member

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate we can't extend an enum from a separate specification.

@anssiko
Copy link
Member

anssiko commented Jan 25, 2019

Yes, partial enum is still not a thing. The topic been discussed in this group earlier w3c/sensors#22 (comment)

@anssiko anssiko merged commit 39bea48 into w3c:gh-pages Jan 25, 2019
@Honry Honry deleted the add-mock-sensor-type branch January 28, 2019 01:28
@Honry
Copy link
Contributor Author

Honry commented Jan 28, 2019

@anssiko, @reillyeon, many thanks for your review!
Seems the enum is still non linkable, any idea?

@anssiko
Copy link
Member

anssiko commented Jan 28, 2019

@Honry bikeshed update --anchors will fix it, see https://tabatkins.github.io/bikeshed/#cli-update

The --anchors flag will update your local Bikeshed "anchor data" to the latest that includes "ambient-light" enum, see https://github.com/tabatkins/bikeshed-data/blob/master/data/anchors/anchors-am.data#L1

Please create a PR to update this spec and also update the other PRs for other concrete specs accordingly.

@anssiko
Copy link
Member

anssiko commented Jan 28, 2019

@Honry since the other PRs did not have any enum linking errors, you probably updated the anchor data between the builds?

@Honry
Copy link
Contributor Author

Honry commented Jan 29, 2019

Oh, I find the root cause now, I did't update the anchor data between the builds, I will do that for all PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants