Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream mock sensor types to corresponding concrete sensor specs #378

Closed
Honry opened this issue Jan 18, 2019 · 5 comments
Closed

Upstream mock sensor types to corresponding concrete sensor specs #378

Honry opened this issue Jan 18, 2019 · 5 comments
Assignees

Comments

@Honry
Copy link
Contributor

Honry commented Jan 18, 2019

Have a standalone issue for better tracking @anssiko's suggestion:

All - would you prefer to see mock sensor types (sections 9.1.3.*) integrated into corresponding concrete sensor specs? That might make maintenance easier if/when those specs add new API surface that need to be accompanied with corresponding new mock sensor reading values.

@anssiko
Copy link
Member

anssiko commented Jan 22, 2019

Expanding a bit what I meant with "easier maintenance":

If we add mock sensor types into Generic Sensor API, that spec in practice turn into a "Living Standard", since every time a new concrete sensor is specified mock sensor types section need to be updated accordingly.

@reillyeon reillyeon assigned reillyeon and Honry and unassigned reillyeon Jan 23, 2019
Honry added a commit to Honry/ambient-light that referenced this issue Jan 25, 2019
Honry added a commit to Honry/accelerometer that referenced this issue Jan 28, 2019
Honry added a commit to Honry/accelerometer that referenced this issue Jan 28, 2019
Honry added a commit to Honry/magnetometer that referenced this issue Jan 28, 2019
Honry added a commit to Honry/magnetometer that referenced this issue Jan 28, 2019
Honry added a commit to Honry/magnetometer that referenced this issue Jan 28, 2019
Honry added a commit to Honry/orientation-sensor that referenced this issue Jan 28, 2019
Honry added a commit to Honry/geolocation-sensor that referenced this issue Jan 28, 2019
Honry added a commit to Honry/proximity that referenced this issue Jan 28, 2019
Honry added a commit to Honry/geolocation-sensor that referenced this issue Jan 28, 2019
Honry added a commit to Honry/magnetometer that referenced this issue Jan 28, 2019
@anssiko
Copy link
Member

anssiko commented Jan 28, 2019

I've now merged all the PRs to concrete sensors.

@Honry you can now create a PR to remove the text that was upstreamed to concrete sensors. Please check that the Bikeshed anchor data remains in a consistent state after the move is completed.

Honry added a commit to Honry/sensors that referenced this issue Jan 29, 2019
Which has been upstreamed to concrete sensor specs.
Fixes w3c#378
@Honry
Copy link
Contributor Author

Honry commented Jan 29, 2019

Thanks, @anssiko.

I've removed the text in #380, and one more concern in my mind, do we need to add a section to describe how to extend mock sensor type to extension specifications to the Extensibility?

@anssiko
Copy link
Member

anssiko commented Jan 29, 2019

Yes indeed. Can you craft a separate PR for the extensibility section about that?

@Honry
Copy link
Contributor Author

Honry commented Jan 30, 2019

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants