Rewrite Automation section after w3c/sensors#470 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed. This commit adapts the Ambient Light Sensor spec to the changes: * Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum. * Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "ambient-light" entry in MockSensorType and an appropriate virtual sensor metadata entry. This is enough to integrate properly with the Generic Sensor spec and allow Ambient Light virtual sensors to be created and used. Fixes w3c#86.
rakuco
reviewed
Oct 20, 2023
| This section extends the [=automation=] section defined in the Generic Sensor API [[GENERIC-SENSOR]] | ||
| to provide mocking information about the ambient light levels for the purposes of testing a user agent's | ||
| implementation of [=Ambient Light Sensor=]. | ||
| This section extends [[GENERIC-SENSOR#automation]] by providing [=Ambient Light Sensor=]-specific virtual sensor metadata. |
There was a problem hiding this comment.
Can you add an extra empty line before this paragraph? Apparently Bikeshed requires that in order to wrap all the paragraphs around <p> tags, which is something I've just noticed and will also need to fix in the Gyroscope spec.
There was a problem hiding this comment.
Empty line added in 7bbbbfa
Now algorithm paragraph also better shows as its own separate paragraph.
|
@anssiko can you merge this one? |
anssiko
approved these changes
Oct 20, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 20, 2023
…rences SHA: 2f5cf3f Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.
This commit adapts the Ambient Light Sensor spec to the changes:
This is enough to integrate properly with the Generic Sensor spec and allow Ambient Light virtual sensors to be created and used.
Fixes #86.
Preview | Diff