Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the Automation section and redefine the spec's extension commands #470

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

rakuco
Copy link
Member

@rakuco rakuco commented Aug 11, 2023

The previous version from #369 and #377 was never implemented by any engines, and the language it used made it hard to actually implement and use in tests (such as those already present in web-platform-tests). For example:

  • Mock sensors acted like a mix of device sensors and platform sensors, and the distinction was not entirely clear.
  • Mock sensors had a separate readings map that never really integrated with the "latest reading" concept used in the abstract operations.
  • The language in the "Create mock sensor" extension command did not make it clear if it was attempting to create Sensor objects or hand-wavingly change existing Sensor objects' associated platform sensor.
  • Implementing the custom WebDriver error codes specified here was not trivial and did not bring much extra benefit (other specifications refrain from doing it as well).
  • Calling "convert to an IDL value" to convert JSON Objects to a platform version is not always trivial to implement since it actually requires a lot of extra WebIDL processing steps that are not really needed here.

The new version uses more precise language in the algorithms and properly integrates into the existing abstract operations. It has also been verified to work with Chromium, ChromeDriver and the required changes to web-platform-tests.

"Mock sensors" are now called "virtual sensors" to follow the same terminology adopted by the WebAuthn spec.

Conceptually, they are now defined as device sensors and therefore always exist at a layer below a platform sensor. This clears up ambiguities and delimits what is expected of platform sensors and what can actually be influenced by a virtual sensor.

Some auxiliary concepts also had to be defined, both of which are expected to be set by extension specifications:

  • "Virtual sensor metadata" is a struct with a sensor type and an algorithm to parse the readings sent to the "update virtual sensor reading" extension command.
  • "Per-type virtual sensor metadata" is a mapping of strings to virtual sensor metadata instances. This allows us to get rid of MockSensorType, as the keys are then used to identify a given sensor type in the WebDriver extension commands and each specification defines one or more keys.

The same virtual sensors are used by all navigables that have the same top-level traversable. In other words, all iframes under the same main frame, regardless of their origin, share the same virtual sensors. Not only does this match the behavior of real, hardware-based sensors more closely, but it also helps with a limitation in web-platform-tests' testdriver.js that only allows WebDriver communication to go through the page that creates the test harness.


Preview | Diff

…ands

The previous version from #369 and #377 was never implemented by any
engines, and the language it used made it hard to actually implement and use
in tests (such as those already present in web-platform-tests). For example:
- Mock sensors acted like a mix of device sensors and platform sensors, and
  the distinction was not entirely clear.
- Mock sensors had a separate readings map that never really integrated with
  the "latest reading" concept used in the abstract operations.
- The language in the "Create mock sensor" extension command did not make it
  clear if it was attempting to create Sensor objects or hand-wavingly
  change existing Sensor objects' associated platform sensor.
- Implementing the custom WebDriver error codes specified here was not
  trivial and did not bring much extra benefit (other specifications refrain
  from doing it as well).
- Calling "convert to an IDL value" to convert JSON Objects to a platform
  version is not always trivial to implement since it actually requires a
  lot of extra WebIDL processing steps that are not really needed here.

The new version uses more precise language in the algorithms and properly
integrates into the existing abstract operations. It has also been verified
to work with Chromium, ChromeDriver and the required changes to
web-platform-tests.

"Mock sensors" are now called "virtual sensors" to follow the same
terminology adopted by the WebAuthn spec.

Conceptually, they are now defined as device sensors and therefore always
exist at a layer below a platform sensor. This clears up ambiguities and
delimits what is expected of platform sensors and what can actually be
influenced by a virtual sensor.

Some auxiliary concepts also had to be defined, both of which are expected
to be set by extension specifications:
- "Virtual sensor metadata" is a struct with a sensor type and an algorithm
  to parse the readings sent to the "update virtual sensor reading"
  extension command.
- "Per-type virtual sensor metadata" is a mapping of strings to virtual
  sensor metadata instances. This allows us to get rid of MockSensorType, as
  the keys are then used to identify a given sensor type in the WebDriver
  extension commands and each specification defines one or more keys.

The same virtual sensors are used by all navigables that have the same
top-level traversable. In other words, all iframes under the same main
frame, regardless of their origin, share the same virtual sensors. Not only
does this match the behavior of real, hardware-based sensors more closely,
but it also helps with a limitation in web-platform-tests' testdriver.js
that only allows WebDriver communication to go through the page that creates
the test harness.
@rakuco rakuco requested a review from reillyeon August 11, 2023 14:50
@rakuco
Copy link
Member Author

rakuco commented Aug 11, 2023

@reillyeon the cleanup pull requests I've been sending have also helped pave the way for this one, as I needed some clear concepts I could hook into for this to work.

Overall, there was a change in terminology (s/mock/virtual/) and the virtual sensors are treated like device sensors. The rest is of the PR contains more precise algorithms for the extension commands + changes to the main operations so that they integrate with virtual sensors.

@rakuco
Copy link
Member Author

rakuco commented Aug 28, 2023

@reillyeon I was wondering if you've had time to take a look at this one? I was hoping to land this PR before TPAC to send the corresponding web-platform-tests changes and ask reviewers to look at them during TPAC if necessary.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
rakuco added a commit to rakuco/wpt that referenced this pull request Sep 11, 2023
Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to web-platform-tests#9686.
rakuco added a commit to rakuco/wpt that referenced this pull request Sep 12, 2023
Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to web-platform-tests#9686.
rakuco added a commit to rakuco/wpt that referenced this pull request Sep 12, 2023
Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to web-platform-tests#9686.
rakuco added a commit to rakuco/wpt that referenced this pull request Sep 12, 2023
Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to web-platform-tests#9686.
@rakuco
Copy link
Member Author

rakuco commented Oct 4, 2023

@reillyeon friendly ping

@rakuco
Copy link
Member Author

rakuco commented Oct 6, 2023

Thank you!

@rakuco rakuco merged commit 50ea817 into main Oct 6, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Oct 6, 2023
…ands (#470)

SHA: 50ea817
Reason: push, by rakuco

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rakuco added a commit to rakuco/wpt that referenced this pull request Oct 10, 2023
Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to web-platform-tests#9686.
rakuco added a commit to rakuco/wpt that referenced this pull request Oct 10, 2023
Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to web-platform-tests#9686.
rakuco added a commit to rakuco/wpt that referenced this pull request Oct 10, 2023
Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to web-platform-tests#9686.
rakuco added a commit to rakuco/wpt that referenced this pull request Oct 10, 2023
Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to web-platform-tests#9686.
@rakuco rakuco deleted the webdriver-ng branch October 17, 2023 09:04
rakuco added a commit to rakuco/gyroscope that referenced this pull request Oct 17, 2023
The Automation section in the Generic Sensor API specification was rewritten
and several terms and concepts have changed.

This commit adapts the Gyroscope spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and
  the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is
  what used to be the "gyroscope" entry in MockSensorType and an appropriate
  virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow
Gyroscope virtual sensors to be created and used.

Fixes w3c#51.
rakuco added a commit to rakuco/gyroscope that referenced this pull request Oct 17, 2023
The Automation section in the Generic Sensor API specification was rewritten
and several terms and concepts have changed.

This commit adapts the Gyroscope spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and
  the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is
  what used to be the "gyroscope" entry in MockSensorType and an appropriate
  virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow
Gyroscope virtual sensors to be created and used.

Fixes w3c#51.
JuhaVainio added a commit to JuhaVainio/ambient-light that referenced this pull request Oct 18, 2023
The Automation section in the Generic Sensor API specification was rewritten
and several terms and concepts have changed.

This commit adapts the Ambient Light Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and
  the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is
  what used to be the "ambient-light" entry in MockSensorType and an appropriate
  virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow
Ambient Light virtual sensors to be created and used.

Fixes w3c#86.
anssiko added a commit to w3c/gyroscope that referenced this pull request Oct 18, 2023
JuhaVainio added a commit to JuhaVainio/ambient-light that referenced this pull request Oct 18, 2023
The Automation section in the Generic Sensor API specification was rewritten
and several terms and concepts have changed.

This commit adapts the Ambient Light Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and
  the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is
  what used to be the "ambient-light" entry in MockSensorType and an appropriate
  virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow
Ambient Light virtual sensors to be created and used.

Fixes w3c#86.
JuhaVainio added a commit to JuhaVainio/ambient-light that referenced this pull request Oct 20, 2023
The Automation section in the Generic Sensor API specification was rewritten
and several terms and concepts have changed.

This commit adapts the Ambient Light Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and
  the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is
  what used to be the "ambient-light" entry in MockSensorType and an appropriate
  virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow
Ambient Light virtual sensors to be created and used.

Fixes w3c#86.
JuhaVainio added a commit to JuhaVainio/ambient-light that referenced this pull request Oct 20, 2023
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Ambient Light Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "ambient-light" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Ambient Light virtual sensors to be created and used.

Fixes w3c#86.
anssiko added a commit to w3c/ambient-light that referenced this pull request Oct 20, 2023
past pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 21, 2023
Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to #9686.
JuhaVainio added a commit to JuhaVainio/orientation-sensor that referenced this pull request Oct 23, 2023
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Orientation Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "absolute-orientation" or "relative-orientation" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Orientation virtual sensors to be created and used.

Fixes w3c#77.
JuhaVainio added a commit to JuhaVainio/geolocation-sensor that referenced this pull request Oct 25, 2023
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Geolocation Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "geolocation" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Geolocation virtual sensors to be created and used.

Fixes w3c#55.
JuhaVainio added a commit to JuhaVainio/magnetometer that referenced this pull request Oct 25, 2023
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Magnetometer Sensor spec to the changes:

Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "magnetometer" or "uncalibrated-magnetometer" entry in MockSensorType and an appropriate virtual sensor metadata entry.
This is enough to integrate properly with the Generic Sensor spec and allow Magnetometer and Uncalibrated Magnetometer virtual sensors to be created and used.

Fixes w3c#65.
JuhaVainio added a commit to JuhaVainio/proximity that referenced this pull request Oct 25, 2023
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Proximity Sensor spec to the changes:

Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "proximity" entry in MockSensorType and an appropriate virtual sensor metadata entry.
This is enough to integrate properly with the Generic Sensor spec and allow Proximity virtual sensors to be created and used.

Fixes w3c#56.
rakuco pushed a commit to w3c/orientation-sensor that referenced this pull request Oct 25, 2023
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Orientation Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "absolute-orientation" or "relative-orientation" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Orientation virtual sensors to be created and used.

Fixes #77.
github-actions bot added a commit to w3c/orientation-sensor that referenced this pull request Oct 25, 2023
SHA: aff9350
Reason: push, by rakuco

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
anssiko added a commit to w3c/proximity that referenced this pull request Oct 26, 2023
anssiko added a commit to w3c/magnetometer that referenced this pull request Oct 26, 2023
anssiko added a commit to w3c/geolocation-sensor that referenced this pull request Oct 26, 2023
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 1, 2023
…ands to testdriver, a=testonly

Automatic update from web-platform-tests
sensors: Add virtual sensor-related commands to testdriver (#41906)

Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to #9686.
--

wpt-commits: 52115b2fd161d1c1c081b56262937a3d67839133
wpt-pr: 41906
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Nov 2, 2023
…ands to testdriver, a=testonly

Automatic update from web-platform-tests
sensors: Add virtual sensor-related commands to testdriver (#41906)

Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with @JuhaVainio.

Related to #9686.
--

wpt-commits: 52115b2fd161d1c1c081b56262937a3d67839133
wpt-pr: 41906
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 8, 2023
…ands to testdriver, a=testonly

Automatic update from web-platform-tests
sensors: Add virtual sensor-related commands to testdriver (#41906)

Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with JuhaVainio.

Related to #9686.
--

wpt-commits: 52115b2fd161d1c1c081b56262937a3d67839133
wpt-pr: 41906

UltraBlame original commit: 0838abe0dccb344e5949267d8e25986191c55fc2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 8, 2023
…ands to testdriver, a=testonly

Automatic update from web-platform-tests
sensors: Add virtual sensor-related commands to testdriver (#41906)

Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with JuhaVainio.

Related to #9686.
--

wpt-commits: 52115b2fd161d1c1c081b56262937a3d67839133
wpt-pr: 41906

UltraBlame original commit: 0838abe0dccb344e5949267d8e25986191c55fc2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 8, 2023
…ands to testdriver, a=testonly

Automatic update from web-platform-tests
sensors: Add virtual sensor-related commands to testdriver (#41906)

Spec PR: w3c/sensors#470

The Generic Sensor spec used to have an Automation section, but it leaked
implementation-specific details and was not implemented anywhere. The
changes above have been implemented in Chromium and there are pending
patches there to convert the existing Generic Sensor web tests in WPT to the
new virtual sensor model, which entirely removes the dependency on Mojo
mocks and makes the tests more interoperable.

This PR adds the required infrastructure to manipulate virtual sensors from
testdriver. The 4 new commands correspond to the 4 WebDriver extension
commands added by the spec PR above.

This change was co-authored with JuhaVainio.

Related to #9686.
--

wpt-commits: 52115b2fd161d1c1c081b56262937a3d67839133
wpt-pr: 41906

UltraBlame original commit: 0838abe0dccb344e5949267d8e25986191c55fc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants