Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Automation section after w3c/sensors#470 #78

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

JuhaVainio
Copy link
Contributor

@JuhaVainio JuhaVainio commented Oct 23, 2023

The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Orientation Sensor spec to the changes:

  • Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
  • Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "absolute-orientation" or "relative-orientation" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Orientation virtual sensors to be created and used.

Fixes #77.


Preview | Diff

The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Orientation Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "absolute-orientation" or "relative-orientation" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Orientation virtual sensors to be created and used.

Fixes w3c#77.
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Dnf is used when link to specific heading or text is needed elsewhere in text.
In this case there was no need or use for links to these specific headings.
Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rakuco rakuco merged commit aff9350 into w3c:main Oct 25, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 25, 2023
SHA: aff9350
Reason: push, by rakuco

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken references in Orientation Sensor
2 participants