-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Automation section after w3c/sensors#470 #78
Merged
rakuco
merged 5 commits into
w3c:main
from
JuhaVainio:update-automation-section-references
Oct 25, 2023
Merged
Rewrite Automation section after w3c/sensors#470 #78
rakuco
merged 5 commits into
w3c:main
from
JuhaVainio:update-automation-section-references
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed. This commit adapts the Orientation Sensor spec to the changes: * Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum. * Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "absolute-orientation" or "relative-orientation" entry in MockSensorType and an appropriate virtual sensor metadata entry. This is enough to integrate properly with the Generic Sensor spec and allow Orientation virtual sensors to be created and used. Fixes w3c#77.
rakuco
suggested changes
Oct 23, 2023
rakuco
suggested changes
Oct 24, 2023
Dnf is used when link to specific heading or text is needed elsewhere in text. In this case there was no need or use for links to these specific headings.
rakuco
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
github-actions bot
added a commit
that referenced
this pull request
Oct 25, 2023
SHA: aff9350 Reason: push, by rakuco Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.
This commit adapts the Orientation Sensor spec to the changes:
This is enough to integrate properly with the Generic Sensor spec and allow Orientation virtual sensors to be created and used.
Fixes #77.
Preview | Diff