Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken references in Orientation Sensor #77

Closed
4 tasks
dontcallmedom-bot opened this issue Oct 11, 2023 · 2 comments · Fixed by #78, #80 or w3c/strudy#479
Closed
4 tasks

Broken references in Orientation Sensor #77

dontcallmedom-bot opened this issue Oct 11, 2023 · 2 comments · Fixed by #78, #80 or w3c/strudy#479
Assignees

Comments

@dontcallmedom-bot
Copy link

While crawling Orientation Sensor, the following links to other specifications were detected as pointing to non-existing anchors:

This issue was detected and reported semi-automatically by Strudy based on data collected in webref.

@anssiko
Copy link
Member

anssiko commented Oct 11, 2023

@rakuco these links need to be updated to match w3c/sensors@50ea817

Similarly for other sensor APIs that refer to automation-related constructs. There are separate issues for each of those specs.

JuhaVainio added a commit to JuhaVainio/orientation-sensor that referenced this issue Oct 23, 2023
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Orientation Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "absolute-orientation" or "relative-orientation" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Orientation virtual sensors to be created and used.

Fixes w3c#77.
rakuco pushed a commit to rakuco/orientation-sensor that referenced this issue Oct 24, 2023
…spec

Contrary to other specifications such as Accelerometer and Gyroscope, this
specification did not define a sensor type for each of the concrete
Orientation Sensors -- there was only a definition for Orientation Sensor
itself.

The concept of inheritance between concepts is not really defined, so we
should have sensor type definitions for absolute and relative orientation
sensors explicitly written out as required by
https://w3c.github.io/sensors/#model-sensor-type, especially to fix w3c#77, as
some automation concepts are hooked to the "sensor type" concept.
@rakuco
Copy link
Member

rakuco commented Oct 24, 2023

Oops, the phrasing in #80's message caused GitHub to close this one. Reopening.

@rakuco rakuco reopened this Oct 24, 2023
rakuco pushed a commit that referenced this issue Oct 25, 2023
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Orientation Sensor spec to the changes:
* Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
* Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "absolute-orientation" or "relative-orientation" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Orientation virtual sensors to be created and used.

Fixes #77.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment