sensors: Add virtual sensor-related commands to testdriver #41906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
docs
infra
testdriver.js
wptrunner
wpt-pr-bot
requested review from
DanielRyanSmith,
foolip,
jgraham and
sideshowbarker
rakuco
force-pushed
the
sensors/add-virtual-sensor-support
branch
3 times, most recently
from
a4494a3 to
a09b779
Compare
reillyeon
approved these changes
Oct 9, 2023
rakuco
force-pushed
the
sensors/add-virtual-sensor-support
branch
from
a09b779 to
143c222
Compare
wpt-pr-bot
requested review from
AutomatedTester,
jrandolf-2,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
rakuco
force-pushed
the
sensors/add-virtual-sensor-support
branch
2 times, most recently
from
3e8ef2c to
0dd2d80
Compare
Spec PR: w3c/sensors#470 The Generic Sensor spec used to have an Automation section, but it leaked implementation-specific details and was not implemented anywhere. The changes above have been implemented in Chromium and there are pending patches there to convert the existing Generic Sensor web tests in WPT to the new virtual sensor model, which entirely removes the dependency on Mojo mocks and makes the tests more interoperable. This PR adds the required infrastructure to manipulate virtual sensors from testdriver. The 4 new commands correspond to the 4 WebDriver extension commands added by the spec PR above. This change was co-authored with @JuhaVainio. Related to web-platform-tests#9686.
rakuco
force-pushed
the
sensors/add-virtual-sensor-support
branch
from
0dd2d80 to
fd100e9
Compare
|
CI was failing because the newly-added I've pushed a new version without that new test, which I intend to land separately later. |
|
@web-platform-tests/wpt-core-team could someone take a look at this one? |
rakuco
requested review from
past and
foolip
and removed request for
DanielRyanSmith,
foolip,
jgraham,
AutomatedTester,
jrandolf-2,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
Thank you! |
rakuco
pushed a commit
to rakuco/wpt
that referenced
this pull request
Nov 1, 2023
This was originally part of web-platform-tests#41906, but these tests are being landed separately because they depend on the corresponding ChromeDriver bits that have since landed. Co-authored with @JuhaVainio, related to web-platform-tests#9686.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec PR: w3c/sensors#470
The Generic Sensor spec used to have an Automation section, but it leaked implementation-specific details and was not implemented anywhere. The changes above have been implemented in Chromium and there are pending patches there to convert the existing Generic Sensor web tests in WPT to the new virtual sensor model, which entirely removes the dependency on Mojo mocks and makes the tests more interoperable.
This PR adds the required infrastructure to manipulate virtual sensors from testdriver. The 4 new commands correspond to the 4 WebDriver extension commands added by the spec PR above.
This change was co-authored with @JuhaVainio.
Related to #9686.