sensors: Add content_shell code path for virtual sensors manipulation #41411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 10, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4770865
branch
2 times, most recently
from
b546d0e to
d08a056
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4770865
branch
6 times, most recently
from
844a983 to
81c8024
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4770865
branch
4 times, most recently
from
9417f96 to
adb9a2e
Compare
content_shell does not use ChromeDriver, so we need a separate implementation for the testdriver.js commands we are adding. This implementation is anchored on Blink's Internals system, which uses the newly-added WebSensorProviderAutomation Mojo interface implemented by content/web_test/browser's WebTestSensorProviderManager to translate the virtual sensor calls into calls to WebContentsSensorProviderProxy that will ultimately reach //services. Bug: 1278377 Change-Id: I13f49d529b36916d1f98b4792839e818fd7e8bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4770865 Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1212214}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4770865
branch
from
adb9a2e to
6328604
Compare
|
For the record, this change was landed as part of #41906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content_shell does not use ChromeDriver, so we need a separate
implementation for the testdriver.js commands we are adding.
This implementation is anchored on Blink's Internals system, which uses
the newly-added WebSensorProviderAutomation Mojo interface implemented
by content/web_test/browser's WebTestSensorProviderManager to translate
the virtual sensor calls into calls to WebContentsSensorProviderProxy
that will ultimately reach //services.
Bug: 1278377
Change-Id: I13f49d529b36916d1f98b4792839e818fd7e8bdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4770865
Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1212214}