Rewrite Automation section after w3c/sensors#470 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed. This commit adapts the Gyroscope spec to the changes: * Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum. * Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "gyroscope" entry in MockSensorType and an appropriate virtual sensor metadata entry. This is enough to integrate properly with the Generic Sensor spec and allow Gyroscope virtual sensors to be created and used. Fixes w3c#51.
reillyeon
approved these changes
Oct 17, 2023
|
Thanks @rakuco and @reillyeon! @dontcallmedom-bot is helpful in catching these, and maybe a future version will submit PRs 🤖 |
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2023
SHA: 62c9f1e Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rakuco
added a commit
to rakuco/gyroscope
that referenced
this pull request
Oct 20, 2023
Follow-up to w3c#52: the lack of the empty line there causes Bikeshed not to add the required <p> tags to the paragraphs in the section.
This was referenced Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.
This commit adapts the Gyroscope spec to the changes:
This is enough to integrate properly with the Generic Sensor spec and allow Gyroscope virtual sensors to be created and used.
Fixes #51.
Preview | Diff