Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Automation section after w3c/sensors#470 #69

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

JuhaVainio
Copy link
Contributor

@JuhaVainio JuhaVainio commented Oct 25, 2023

The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Magnetometer Sensor spec to the changes:

  • Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
  • Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "magnetometer" or "uncalibrated-magnetometer" entry in MockSensorType and an appropriate virtual sensor metadata entry.

This is enough to integrate properly with the Generic Sensor spec and allow Magnetometer and Uncalibrated Magnetometer virtual sensors to be created and used.

Fixes #65.


Preview | Diff

The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.

This commit adapts the Magnetometer Sensor spec to the changes:

Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum.
Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "magnetometer" or "uncalibrated-magnetometer" entry in MockSensorType and an appropriate virtual sensor metadata entry.
This is enough to integrate properly with the Generic Sensor spec and allow Magnetometer and Uncalibrated Magnetometer virtual sensors to be created and used.

Fixes w3c#65.
@JuhaVainio JuhaVainio requested a review from rakuco October 25, 2023 07:56
@JuhaVainio
Copy link
Contributor Author

I think there needs to be "w3c/orientation-sensor#80" type of change for Uncalibrated Magnetometer too...

@rakuco
Copy link
Member

rakuco commented Oct 25, 2023

Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum. Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "magnetometer" or "uncalibrated-magnetometer" entry in MockSensorType and an appropriate virtual sensor metadata entry. This is enough to integrate properly with the Generic Sensor spec and allow Magnetometer and Uncalibrated Magnetometer virtual sensors to be created and used.

This should be formatted as a list here and in the commit message.

@rakuco
Copy link
Member

rakuco commented Oct 25, 2023

I think there needs to be "w3c/orientation-sensor#80" type of change for Uncalibrated Magnetometer too...

This was done in #66.

index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@JuhaVainio
Copy link
Contributor Author

Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum. Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "magnetometer" or "uncalibrated-magnetometer" entry in MockSensorType and an appropriate virtual sensor metadata entry. This is enough to integrate properly with the Generic Sensor spec and allow Magnetometer and Uncalibrated Magnetometer virtual sensors to be created and used.

This should be formatted as a list here and in the commit message.

Done

… of variables.

Uncalibrated Magnetometer link points now to sensor type which was just added to specification.

Changed parameters to use list mode.

Added ending tag to <div>.
Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@anssiko could you merge this one?

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@anssiko anssiko merged commit d76c769 into w3c:main Oct 26, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Oct 26, 2023
…rences

SHA: d76c769
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken references in Magnetometer
3 participants