-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Automation section after w3c/sensors#470 #69
Rewrite Automation section after w3c/sensors#470 #69
Conversation
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed. This commit adapts the Magnetometer Sensor spec to the changes: Remove references to "mock sensor type", "mock sensor reading values" and the "MockSensorType" enum. Define an entry in the per-type virtual sensor metadata map whose key is what used to be the "magnetometer" or "uncalibrated-magnetometer" entry in MockSensorType and an appropriate virtual sensor metadata entry. This is enough to integrate properly with the Generic Sensor spec and allow Magnetometer and Uncalibrated Magnetometer virtual sensors to be created and used. Fixes w3c#65.
I think there needs to be "w3c/orientation-sensor#80" type of change for Uncalibrated Magnetometer too... |
This should be formatted as a list here and in the commit message. |
This was done in #66. |
Done |
… of variables. Uncalibrated Magnetometer link points now to sensor type which was just added to specification. Changed parameters to use list mode. Added ending tag to <div>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@anssiko could you merge this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
…rences SHA: d76c769 Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The Automation section in the Generic Sensor API specification was rewritten and several terms and concepts have changed.
This commit adapts the Magnetometer Sensor spec to the changes:
This is enough to integrate properly with the Generic Sensor spec and allow Magnetometer and Uncalibrated Magnetometer virtual sensors to be created and used.
Fixes #65.
Preview | Diff