-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure: Remove temp pinning to Node 16 to work around tests failing with Node 18 in CI #2636
Comments
The difference between the recent failing PRs and the passing PRs is the passing PRs were using This issue was identified in SeleniumHQ/selenium#10970 (ISSUE 2). The builds should pass by merging #2635 as this bug was addressed in selenium-webdriver v4.5.0 but that dependabot PR is also failing and I'm unable to reproduce the failure locally. |
May be potentially related to a regression with how |
* Bump ava and selenium-webdriver * (temporary fix tracked by #2636): Force node-version to 16 for regression.yml
#2640 now pins the version back to |
@howard-e, will the bugs associated with Node 18 effect only CI or could it also effect local execution of tests? |
@mcking65 it only affects the tests when running in the GH CI from what I can see. At least, no unexpected errors have been thrown locally for me with node 18 on Windows and MacOS (with some failures due to specific key commands being referenced). |
@mcking65 based on today's APG discussion around #2735, it seems I was wrong about this statement. After repeatedly running the regression tests with MacOS + Node 18 locally, I eventually got the same timeout error that's reported in the top comment of this PR (and it happens for all the tests). Detailed regression tests results when ran on MacOS + Node 18:
For MacOS + Node 16, I'd consistently get the following, which is the same experience described in #2735:
Detailed regression tests results when ran on MacOS + Node 16:
For Windows + Node 16 or 18, I get the expected result when running the regression tests. |
@mcking65 so after discussing this internally, what was found is that Node v17+ deprioritised IPv4 addresses in favour of IPv6 with a change to dns.setDefaultResultOrder. This was done without a happy-eyeballs implementation which meant the loopback address used when running the regression tests resolved to Alternatively, we could have added PR #2749 should resolve this. |
Initially reported by @jongund through an email thread and further supported by the latest set of dependabot updates, all the regression tests are failing with a similar error for each test, when ran with Node 18 in the GitHub Actions:
The error message is
Timed out while waiting for WebDriver server
.The text was updated successfully, but these errors were encountered: