Skip to content

Commit

Permalink
Merge pull request #137 from w3c/source-loc
Browse files Browse the repository at this point in the history
Fix type of sourceCharPosition attribute, and amend explainer
  • Loading branch information
noamr authored Feb 16, 2024
2 parents aec43ed + 5664b38 commit ee95837
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ The {{PerformanceLongAnimationFrameTiming/scripts}} attribute's getter steps are
readonly attribute DOMHighResTimeStamp executionStart;
readonly attribute DOMString sourceURL;
readonly attribute DOMString sourceFunctionName;
readonly attribute DOMString sourceCharPosition;
readonly attribute long long sourceCharPosition;
readonly attribute DOMHighResTimeStamp pauseDuration;
readonly attribute DOMHighResTimeStamp forcedStyleAndLayoutDuration;
readonly attribute Window? window;
Expand Down
4 changes: 3 additions & 1 deletion loaf-explainer.md
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,9 @@ const someLongAnimationFrameEntry = {

// In the case of promise resolver this would be the invoker's source location
// Note that we expose character position rather than line/column to avoid overhead of line splitting.
sourceLocation: "functionName@URL:characterPosition",
sourceURL: "https://example.com/big.js",
sourceFunctionName: "do_something_long",
sourceCharPosition: 10,

// Relationship between the (same-origin) window where this script was executed and
// this window.
Expand Down

0 comments on commit ee95837

Please sign in to comment.