Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify contentful state regarding images that are not foreground/background #56

Closed
noamr opened this issue Mar 3, 2020 · 5 comments
Closed

Clarify contentful state regarding images that are not foreground/background #56

noamr opened this issue Mar 3, 2020 · 5 comments

Comments

@noamr
Copy link
Contributor

noamr commented Mar 3, 2020

For example, mask images should probably be considered contentful.
@npm1
Copy link
Contributor

npm1 commented Mar 3, 2020

Yep, makes sense. Things to do here: add those to the list of contentful, and add a WPT for that.

@noamr
Copy link
Contributor Author

noamr commented Mar 3, 2020

I would be happy to add the WPT once the spec is modified.

npm1 added a commit that referenced this issue Mar 5, 2020
@npm1
Allow mask images to be contentful
69ee083 
@noamr is this what you were hoping for? I'm not sure if this addresses your question or not. This fixes #56
@npm1 npm1 mentioned this issue Mar 5, 2020
Closed
@noamr
Copy link
Contributor Author

noamr commented Mar 11, 2020

Addresses in #66

@noamr noamr closed this as completed Mar 11, 2020
@rniwa
Copy link

rniwa commented Mar 12, 2020

Please don't close an issue until the relevant PR is landed. It's very confusing.

@rniwa rniwa reopened this Mar 12, 2020
@noamr
Copy link
Contributor Author

noamr commented Mar 20, 2020

Closing now that the PR has landed. https://w3c.github.io/paint-timing/

@noamr noamr closed this as completed Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow mask images to be contentful w3c/paint-timing
3 participants
@noamr @rniwa @npm1