-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify what 'contentful' means #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left some comments.
I've gotta say things are looking really good! A few more iterations on this PR should bring a much needed rigor to the definition of contentful. As much as I've been critical of all the phrases in this PR, I can't express enough of my gratitude for all your hard work :) Thanks for all the great work so far & let's keep going with this. |
Thanks, it's important for me to hear this, and I appreciate your rigor and the interest in fleshing out the details. |
e388d8c
to
5a9b959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Setting to "Approval" so you're not blocked on me when everyone else is happy with it.
@rniwa any additional comments or can I merge this? |
d05561c
to
9df1df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits
383f7b1
to
b09a167
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Co-Authored-By: npm1 <npm@chromium.org>
A shot at better defining what "contentful" means in the context of "first contentful paint". Added "contentful" to the terminology with an attempt at a precise definition with proper references.
Gave clear definitions of images, canvas, text, and paint rects.
(This is my first try at one of these specs so please bear with me...)
@rniwa, @npm1 wdyt?
Preview | Diff