Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what 'contentful' means #66

Merged
merged 22 commits into from
Mar 20, 2020
Merged

Clarify what 'contentful' means #66

merged 22 commits into from
Mar 20, 2020

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 8, 2020

A shot at better defining what "contentful" means in the context of "first contentful paint". Added "contentful" to the terminology with an attempt at a precise definition with proper references.
Gave clear definitions of images, canvas, text, and paint rects.

(This is my first try at one of these specs so please bear with me...)

@rniwa, @npm1 wdyt?


Preview | Diff

Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left some comments.

painttiming.bs Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
@noamr noamr requested a review from yoavweiss March 10, 2020 14:41
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
@npm1 npm1 mentioned this pull request Mar 10, 2020
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
@rniwa
Copy link

rniwa commented Mar 11, 2020

I've gotta say things are looking really good! A few more iterations on this PR should bring a much needed rigor to the definition of contentful. As much as I've been critical of all the phrases in this PR, I can't express enough of my gratitude for all your hard work :) Thanks for all the great work so far & let's keep going with this.

@noamr
Copy link
Contributor Author

noamr commented Mar 11, 2020

I've gotta say things are looking really good! A few more iterations on this PR should bring a much needed rigor to the definition of contentful. As much as I've been critical of all the phrases in this PR, I can't express enough of my gratitude for all your hard work :) Thanks for all the great work so far & let's keep going with this.

Thanks, it's important for me to hear this, and I appreciate your rigor and the interest in fleshing out the details.

@noamr noamr force-pushed the what-is-contentful branch from e388d8c to 5a9b959 Compare March 11, 2020 13:23
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Setting to "Approval" so you're not blocked on me when everyone else is happy with it.

painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
@noamr
Copy link
Contributor Author

noamr commented Mar 12, 2020

@rniwa any additional comments or can I merge this?

painttiming.bs Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
@noamr noamr force-pushed the what-is-contentful branch from d05561c to 9df1df6 Compare March 19, 2020 07:54
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Show resolved Hide resolved
@noamr noamr force-pushed the what-is-contentful branch from 383f7b1 to b09a167 Compare March 19, 2020 08:27
painttiming.bs Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Outdated Show resolved Hide resolved
painttiming.bs Show resolved Hide resolved
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

noamr and others added 2 commits March 20, 2020 09:04
Co-Authored-By: npm1 <npm@chromium.org>
@noamr noamr merged commit 88898cc into master Mar 20, 2020
@noamr noamr deleted the what-is-contentful branch March 20, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants