Validate payment method data #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes w3c#373: align ordering of steps with Blink's implementation, except check for allowed-to-use first since that makes more sense - Fixes w3c#334: properly get the total.amount.value instead of pretending total is a string - Fixes w3c#333 and fixes w3c#335: do not assume various dictionaries are present - Fixes part of w3c#321: use proper dictionary terminology - Ensures request.[[details]].shippingOptions/modifiers is always a sequence, instead of sometimes left as not present - Fixes various algorithm structure and typographic issues
This is part of w3c/payment-method-basic-card#20. What remains is for the basic-card specification to define its validate payment method data algorithm.
domenic
added a commit
to domenic/webpayments-methods-card
that referenced
this pull request
Dec 14, 2016
In combination with w3c/payment-request#381, this fixes w3c#20.
This was referenced Dec 14, 2016
|
Closing since per #307 (comment) this cannot be done synchronously; it needs to happen in another process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of w3c/payment-method-basic-card#20. What remains is for the basic-card specification to define its validate payment method data algorithm.
This is on top of #374 and should not be merged until that is.