Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parachain Staking Milestone 2: UI Dashboard #321

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Dec 8, 2021

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#389

@semuelle
Copy link
Member

semuelle commented Dec 8, 2021

Thank you for the delivery, Amar. We will look into it as soon as possible.

@Noc2 Noc2 self-assigned this Dec 9, 2021
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the delivery. I quickly looked into it and everything seems to work. However, the UI only provides an overview of the current staking initiatives and doesn’t actually let you participate in the staking. Is this on-purpose? I know the deliveries were unspecific in the contract, but I would have expected that you can also stake via the UI.

@4meta5
Copy link
Contributor Author

4meta5 commented Dec 10, 2021

Doesn't actually let you participate in the staking. Is this on-purpose? I know the deliveries were unspecific in the contract, but I would have expected that you can also stake via the UI.

OK, we will add this functionality, but it will require another 2 weeks. I'll let you know as soon as it is done.

Our perspective was that the deliverable needed to display meaningful statistics to educate user staking through whatever custom UI is provided by the implementation. For moonbeam/moonriver, we prefer users use the staking dapp provided by PureStake (https://apps.moonbeam.network/moonriver).

@Noc2
Copy link
Collaborator

Noc2 commented Dec 13, 2021

Thanks for the quick reply. I think it would be beneficial if you add it directly to the UI. Alternatively you could also link to your own staking dapp, to at least inform users about how they can participate.

@alxs
Copy link
Contributor

alxs commented Jan 17, 2022

@4meta5 any updates?

@4meta5
Copy link
Contributor Author

4meta5 commented Jan 17, 2022

@alxs We decided to add the delegate feature to the UI dashboard but it is currently in progress and will be done soon. Our best TS dev @joelamouche is working on it. He was busy with tasks for Moonbeam launch, but is back on this now.

@alxs
Copy link
Contributor

alxs commented Feb 15, 2022

@4meta5 @joelamouche checking in again. Could you provide an ETA?

@crystalin
Copy link

@alxs Sorry, @joelamouche is not working on this project anymore.
Our team took over and I believe it is close to completion. Let me come back you today

@purestaketdb
Copy link

I am onboarding @fxgamundi to the project this week, he'll need to get up to speed on the Polkadot.js libraries but is the developer on our own staking dapp. I'll have more clarity about timelines next week. Note, basic staking is working but the pallet was extended in December and those changes need to be rolled in.

@alxs
Copy link
Contributor

alxs commented Feb 16, 2022

Thanks @crystalin @purestaketdb, sounds good. Please keep us posted.

@fgamundi
Copy link

fgamundi commented Mar 1, 2022

Hi! Nice to meet everyone. I'm currently working on this and will be able to provide an update on the status and an ETA later in the week.

@Noc2
Copy link
Collaborator

Noc2 commented Mar 1, 2022

Perfect. Thanks for the update

@fgamundi
Copy link

fgamundi commented Mar 9, 2022

Hey! Progress is going well and we should have a it ready for review by the end of next week.

@Noc2
Copy link
Collaborator

Noc2 commented Mar 9, 2022

That’s great to hear.

@fgamundi
Copy link

We're doing a final internal review before submitting the updated code. We'll follow with the PR later today

@Noc2
Copy link
Collaborator

Noc2 commented Mar 24, 2022

Sounds good. It’s not super urgent. I’m currently sick (covid) and can not work much anyway ;-)

@fgamundi
Copy link

Sorry to hear that, get better! In that case I will take some additional time to clean a couple of things.

@fgamundi
Copy link

fgamundi commented Mar 30, 2022

Hi! The PR for the parachain staking page is up! polkadot-js/apps#7275. This PR replaces the previous one.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply here. I’m happy to tell you that the milestone is a pass and thanks for all the extra effort you put into this. I will forward your invoice internally.

@Noc2 Noc2 merged commit 87bad20 into w3f:master Apr 4, 2022
@meldien
Copy link

meldien commented Apr 4, 2022

Hi all, is it possible to update the invoice date?

@4meta5 4meta5 deleted the parachain-staking-m2 branch April 5, 2022 15:39
@4meta5 4meta5 restored the parachain-staking-m2 branch April 5, 2022 15:39
@4meta5 4meta5 deleted the parachain-staking-m2 branch April 5, 2022 15:42
@4meta5
Copy link
Contributor Author

4meta5 commented Apr 5, 2022

@Noc2 @meldien the invoice was submitted via the google form from what I remember? would you like us to submit a new invoice via the google form?

@meldien
Copy link

meldien commented Apr 6, 2022

@4meta5 @Noc2 yes that would be great if you can submit a new invoice during google form. because the date is from 2021 and the approval are done in 2022.

@meldien
Copy link

meldien commented Apr 11, 2022

@4meta5 any update?

@4meta5
Copy link
Contributor Author

4meta5 commented Apr 13, 2022

@meldien we have assigned the task of sending the new invoice to someone else internally and will submit it soon cc @crystalin

@fededubbi
Copy link

Hi all, any updates here?

Many thanks,
Federica

@4meta5
Copy link
Contributor Author

4meta5 commented Apr 20, 2022

I submitted an updated invoice. Let me know if there are any problems with the submission.

@RouvenP
Copy link

RouvenP commented May 2, 2022

hi @4meta5 we transferred the payment today. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants