Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds parachain staking grant proposal #389

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

crystalin
Copy link
Contributor

Grant Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • A BTC or Ethereum (DAI) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledged the Terms and Conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants.
  • The initial PR contains only one commit (squash if needed before submitting your PR).
  • The grant will only be announced once the first milestone has been accepted.

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2021

CLA assistant check
All committers have signed the CLA.

@crystalin crystalin changed the title Adds parachain staking Adds parachain staking grant proposal Apr 22, 2021
Copy link
Contributor

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crystalin Thanks for the application, looks pretty good. The only change that I'd like to request is changing the currency, because as of recently we only pay in DAI for Open Grants.

@crystalin
Copy link
Contributor Author

The PR is not updating after pushing changes to the branch, I'm closing/re-opening the PR

@crystalin crystalin closed this Apr 23, 2021
@crystalin crystalin reopened this Apr 23, 2021
@crystalin
Copy link
Contributor Author

@mmagician I've updated the currency/address

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. Could you potentially also add the deliveries 0a to 0d to the application, see https://github.com/w3f/Open-Grants-Program/blob/master/applications/application-template.md#milestone-1-example--implement-substrate-modules. At least the license should be included. Regarding milestone 2, would it potentially be possible to also make a pr to integrate this into polkadot.js apps itself?

@Noc2 Noc2 self-assigned this Apr 29, 2021
@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Apr 29, 2021
@4meta5
Copy link
Contributor

4meta5 commented Apr 30, 2021

@Noc2 I made the requested changes, let me know if they are OK. I can change the licenses if necessary.

Copy link
Contributor

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'm looking forward to see this integrated!

@mmagician mmagician added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Apr 30, 2021
@alxs alxs merged commit 3be24dd into w3f:master Apr 30, 2021
@github-actions
Copy link
Contributor

Congratulations! As part of the Open Grants Program, we want to help winning teams acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully delivered their first milestone. Please observe the foundation’s guidelines when making any announcements; in particular, don’t announce the grant publicly before you've completed at least the first milestone of the project.

At that point, we will be happy to collaborate on an announcement about the work you’re doing. Please get in touch with us at grantspr@web3.foundation in case you're interested (at least two weeks notice is preferred).

@crystalin crystalin deleted the crystalin-parachain-staking branch April 30, 2021 20:25
chrisli30 pushed a commit to AvaProtocol/W3F-Grants-Fork that referenced this pull request May 31, 2021
* Adds parachain staking

* Updates payment currency from BTC to DAI

* address review comments

Co-authored-by: 4meta5 <asinghchrony@protonmail.com>
@alxs
Copy link
Contributor

alxs commented Oct 7, 2021

Hey @crystalin @4meta5, care to share a quick status update on your second milestone?

@crystalin
Copy link
Contributor Author

Sorry @alxs, the person in charge of providing the 2nd milestone has left and I've been having a hard time finding someone to take over.
Let me re-evaluate the amount of work needed with @4meta5 and come back to you

@crystalin
Copy link
Contributor Author

@alxs , we have resumed the work on the 2nd milestone. No ETA at the moment, but I would suspect few weeks of work should be enough

@alxs
Copy link
Contributor

alxs commented Oct 18, 2021

@crystalin sounds good, thanks for the update. Please keep us posted.

@4meta5
Copy link
Contributor

4meta5 commented Nov 29, 2021

@alxs 2 updates:

  1. Recent refactor of the 1st milestone parachain-staking pallet in [Staking] Make exits manual, patch lack of delay for {increasing, decreasing} bonds moonbeam-foundation/moonbeam#810 . This PR changed the naming conventions from NPoS to DPoS. It also optimized the exits so that they are no longer scheduled to be automatically executed in on_initialize (which had led to large (sometimes overweight) blocks at round transitions). These changes are included in the upcoming NCC audit.
  2. The 2nd milestone work is complete Add parachain staking panel polkadot-js/apps#6430 but the PR is awaiting review. We are waiting for it to be approved and merged before formally submitting the milestone.

@alxs
Copy link
Contributor

alxs commented Nov 30, 2021

Hey, thanks a lot for keeping us updated. Very happy to hear that. Freel free to go ahead and submit milestone 2 before it's accepted to polkadot-js/apps, we can already start looking into it and potentially also review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants