Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript broken with Sphinx 6 #250

Closed
vsalvino opened this issue Mar 6, 2023 · 0 comments · Fixed by #252
Closed

JavaScript broken with Sphinx 6 #250

vsalvino opened this issue Mar 6, 2023 · 0 comments · Fixed by #252

Comments

@vsalvino
Copy link
Contributor

vsalvino commented Mar 6, 2023

Sphinx 6 removed jquery, and it seems our theme is still using it, hence JavaScript functionality, such as the search, is broken if the docs are built using Sphinx 6.

I would recommend we also remove jquery, since I don't think we are using it very much; however as a quick fix there is an official sphinx jquery plugin. See: https://www.sphinx-doc.org/en/master/changes.html#id42

I will look into doing this, once I have some free time.
lb- pushed a commit to lb-/sphinx_wagtail_theme that referenced this issue Mar 8, 2023
Remove jQuery loading by default
7e799a1 
- Sill used as a peer dependency of Bootstrap
- Core jQuery dependency removed though
- Fixes wagtail#250
@lb- lb- mentioned this issue Mar 8, 2023
Merged
thibaudcolas pushed a commit that referenced this issue Mar 9, 2023
@lb-
Remove jQuery loading by default (#252)
1e4d8e1 
- Sill used as a peer dependency of Bootstrap
- Core jQuery dependency removed though
- Fixes #250

Co-authored-by: LB Johnston <lb.johnston@virginaustralia.com>
@lb- lb- mentioned this issue Mar 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove jQuery loading by default lb-/sphinx_wagtail_theme
1 participant
@vsalvino