Remove jQuery loading by default #252
Conversation
lb-
commented
Mar 8, 2023
lb-
commented
- Sill used as a peer dependency of Bootstrap
- Core jQuery dependency removed though
- Fixes JavaScript broken with Sphinx 6 #250
- Sill used as a peer dependency of Bootstrap - Core jQuery dependency removed though - Fixes wagtail#250
|
@vsalvino is this what you were thinking? Note: I have not dug into JS usage of bootstrap, it appears we are not really using anything but I have left it importing in At least we can see a deployment and have a look. |
|
That should do it. I think the only bootstrap JS feature we may be using is the mobile menu... does that still work correctly with this change? |
|
P.S... bootstrap 5 did remove jquery as a dependency. Not sure how broken that would be to upgrade, or if it would be a mostly drop-in replacement given our minimal bootstrap usage. https://getbootstrap.com/docs/5.2/migration/ |
|
The mobile menu expander works fine in the build but it could be driven by the peer dep. Yeah maybe BS 5 is an option. I might not get the chance to look at this one again for a bit though |
|
I think this looks good then. I'll look into Bootstrap 5 when I get a chance. |
|
Thank you both! |
thibaudcolas
added
bug
|
Bootstrap 5 discussion moved to a new issue #254 |
