Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicit nwaku subscriptions in tests #1572

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Sep 15, 2023

Problem

When interop testing with nwaku, tests did not subscribe nwaku to the default pubsub topic. Those tests only worked so far because of the default behavior of nwaku WAS to subscribe to the default pubsub topic and cache messages received on it.

With waku-org/nwaku#1983 this is no longer the case.

Solution

Tests that call "get_waku_v2_relay_v1_messages" must call "post_waku_v2_relay_v1_subscriptions" before hand. Otherwise no messages will be cached.

@SionoiS SionoiS changed the title fix: made nwaku subscriptions explicit in tests fix: explicit nwaku subscriptions in tests Sep 15, 2023
@github-actions
Copy link

github-actions bot commented Sep 15, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 28.79 KB (0%) 576 ms (0%) 1.7 s (-8.11% 🔽) 2.3 s
Waku Simple Light Node 310.09 KB (0%) 6.3 s (0%) 5.7 s (+7.56% 🔺) 11.9 s
ECIES encryption 28.68 KB (0%) 574 ms (0%) 1.6 s (+17.13% 🔺) 2.2 s
Symmetric encryption 28.68 KB (0%) 574 ms (0%) 1.6 s (+163.58% 🔺) 2.1 s
DNS discovery 118.59 KB (0%) 2.4 s (0%) 2.8 s (+11.77% 🔺) 5.2 s
Privacy preserving protocols 122.6 KB (0%) 2.5 s (0%) 2.9 s (+17.86% 🔺) 5.4 s
Light protocols 29.25 KB (0%) 585 ms (0%) 1.2 s (-27.35% 🔽) 1.7 s
History retrieval protocols 28.34 KB (0%) 567 ms (0%) 954 ms (-23.67% 🔽) 1.6 s
Deterministic Message Hashing 5.64 KB (0%) 113 ms (0%) 352 ms (-42.89% 🔽) 465 ms

@SionoiS
Copy link
Contributor Author

SionoiS commented Sep 15, 2023

One test is failing but it seams unrelated.

@SionoiS SionoiS marked this pull request as ready for review September 15, 2023 14:58
@SionoiS SionoiS requested a review from a team as a code owner September 15, 2023 14:58
@SionoiS SionoiS self-assigned this Sep 15, 2023
@SionoiS SionoiS force-pushed the fix--explicit-nwaku-subscriptions-in-tests branch from a322b72 to 841bdbb Compare September 19, 2023 13:30
@SionoiS SionoiS requested a review from weboko September 19, 2023 14:51
@weboko weboko merged commit 7905aa4 into master Sep 19, 2023
9 of 10 checks passed
@weboko weboko deleted the fix--explicit-nwaku-subscriptions-in-tests branch September 19, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants