fix: subscription RPC & added test subscriptions #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
weboko
approved these changes
Sep 21, 2023
fryorcraken
reviewed
Sep 21, 2023
| @@ -25,6 +25,8 @@ describe("Waku Light Push [node only] - custom pubsub topic", function () { | |||
| nwaku, | |||
| customPubSubTopic | |||
| ); | |||
|
|
|||
| await nwaku.ensureSubscriptions([customPubSubTopic]); | |||
There was a problem hiding this comment.
We have other tests using a custom pubsub topic, no?
There was a problem hiding this comment.
Yes but subscriptions is required only if you want to check the nwaku message cache.
Yes exactly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I totally messed up my previous PR #1572
This PR should fix the problem for real this time! Sorry about that!