Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize layout with occupancy bitmap #71

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Optimize layout with occupancy bitmap #71

wants to merge 24 commits into from

Conversation

walterra
Copy link
Owner

@walterra walterra commented Nov 29, 2022 •
edited
Loading

Fixes #69.

  • Debug mode displays a canvas based chart to visualize label areas.
  • Overlap removal based on occupancy bitmap
  • Fix edge cases with last element
  • Fix edge cases with label being pushed from bottom despite enough space
  • Fix vertical layout
  • Improve performance 🤪
Before After
image image
image image
image image

@walterra walterra self-assigned this Nov 29, 2022
@walterra walterra mentioned this pull request Dec 20, 2022
Open
@walterra walterra temporarily deployed to test-ui January 12, 2023 13:32 — with GitHub Actions Inactive
@walterra walterra temporarily deployed to test-ui January 12, 2023 15:36 — with GitHub Actions Inactive
@walterra walterra temporarily deployed to test-ui January 12, 2023 17:03 — with GitHub Actions Inactive
@walterra walterra temporarily deployed to test-ui January 12, 2023 17:32 — with GitHub Actions Inactive
@walterra walterra temporarily deployed to test-ui January 13, 2023 08:52 — with GitHub Actions Inactive
walterra added 19 commits January 13, 2023 10:03
@walterra
wip: optimize layout with occupancy bitmap
cca5329
@walterra
wip: layout vertical offset
825998e
@walterra
wip: layout vertical offset improvements
c2ea46b
@walterra
wip: tweak last element
132da36
@walterra
wip: fix nesting of loops.
d12d90c
@walterra
reset padding and 'last' class before starting the optimization
2796d06
@walterra
create bitmap of all elements without current lowest orange
695ddec
@walterra
use occupancy bitmap to resize label
22b9ee9
@walterra
layout tweaks
b32a3c7
@walterra
make debug chart an option
0a2e070
@walterra
still run layout if debug chart canvas element is not present
1c2aad2
@walterra
cleanup
723f841
@walterra
layout upper and lower chart
784f2aa
@walterra
delete unused utils
92ca16e
@walterra
shrink labels to only necessary width
ed0b172
@walterra
create occurrence bitmap only when there's an orange element.
e060349
@walterra
move bitmap generation to helper function
256ad84
@walterra
overlap check to reset labels which overlap with vertical lines of ot…
8cb202f 
…her labels.
@walterra
fix overlap removal edge case bugs
ad6219e
@walterra walterra temporarily deployed to test-ui January 13, 2023 09:03 — with GitHub Actions Inactive
@Montmorency
Copy link

Really like milestones and this PR looks like a big improvement. Are there any specific performance optimizations blocking merge? I'm happy to help test and make PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@walterra walterra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout algorithms based on "Fast and Flexible Overlap Detection for Chart Labeling with Occupancy Bitmap"
2 participants
@walterra @Montmorency