Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize layout with occupancy bitmap #71

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
cca5329
wip: optimize layout with occupancy bitmap
walterra Nov 29, 2022
825998e
wip: layout vertical offset
walterra Nov 29, 2022
c2ea46b
wip: layout vertical offset improvements
walterra Nov 29, 2022
132da36
wip: tweak last element
walterra Nov 29, 2022
d12d90c
wip: fix nesting of loops.
walterra Nov 29, 2022
2796d06
reset padding and 'last' class before starting the optimization
walterra Nov 29, 2022
695ddec
create bitmap of all elements without current lowest orange
walterra Nov 29, 2022
22b9ee9
use occupancy bitmap to resize label
walterra Nov 29, 2022
b32a3c7
layout tweaks
walterra Nov 29, 2022
0a2e070
make debug chart an option
walterra Nov 30, 2022
1c2aad2
still run layout if debug chart canvas element is not present
walterra Nov 30, 2022
723f841
cleanup
walterra Nov 30, 2022
784f2aa
layout upper and lower chart
walterra Nov 30, 2022
92ca16e
delete unused utils
walterra Nov 30, 2022
ed0b172
shrink labels to only necessary width
walterra Nov 30, 2022
e060349
create occurrence bitmap only when there's an orange element.
walterra Nov 30, 2022
256ad84
move bitmap generation to helper function
walterra Nov 30, 2022
8cb202f
overlap check to reset labels which overlap with vertical lines of ot…
walterra Nov 30, 2022
ad6219e
fix overlap removal edge case bugs
walterra Nov 30, 2022
e023d91
bottom margin for debug chart.
walterra Dec 1, 2022
d8714b2
overlap removal tweaks, some performance improvements too.
walterra Dec 1, 2022
87ee6fd
wip: preparation refactor for vertical layout.
walterra Dec 1, 2022
d0dba38
vertical layout fixes
walterra Dec 2, 2022
3686896
layout fixes
walterra Jan 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
},
"extends": [ "eslint:recommended", "plugin:prettier/recommended" ],
"parserOptions": {
"sourceType": "module"
"sourceType": "module",
"ecmaVersion": 8
},
"plugins": ["jest", "prettier"],
"rules": {
Expand Down
1 change: 1 addition & 0 deletions src/_css.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export const cssBulletClass = cssGroupClass + '__bullet';
export const cssLabelClass = cssGroupClass + '__label';
export const cssLastClass = cssLabelClass + '-last';
export const cssAboveClass = cssLabelClass + '-above';
export const cssBelowClass = cssLabelClass + '-below';
export const cssTextClass = cssLabelClass + '__text';
export const cssTitleClass = cssTextClass + '__title';
export const cssEventClass = cssTextClass + '__event';
Expand Down
3 changes: 0 additions & 3 deletions src/_get_attribute.js

This file was deleted.

13 changes: 0 additions & 13 deletions src/_get_attribute.test.js

This file was deleted.

78 changes: 0 additions & 78 deletions src/_get_available_width.js

This file was deleted.

61 changes: 0 additions & 61 deletions src/_get_available_width.test.js

This file was deleted.

29 changes: 0 additions & 29 deletions src/_get_next_group_height.js

This file was deleted.

17 changes: 0 additions & 17 deletions src/_get_next_group_height.test.js

This file was deleted.

Loading