Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): upgrading material ui version #2308

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

mbarrramsey
Copy link
Contributor

@mbarrramsey mbarrramsey commented Sep 4, 2024

Description

Upgrades material UI version to the latest in order to use custom Theme Provider, https://mui.com/material-ui/customization/theming/ to enable better common components for material UI.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

Copy link

socket-security bot commented Sep 4, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@mbarrramsey mbarrramsey marked this pull request as ready for review September 4, 2024 18:35
@mbarrramsey mbarrramsey requested a review from a team as a code owner September 4, 2024 18:35
@circle-job-mirror
Copy link

circle-job-mirror bot commented Sep 4, 2024

@jwlee64
Copy link
Contributor

jwlee64 commented Sep 5, 2024

I believe this might have some breaking changes?
https://mui.com/system/migration/migrating-to-v6/
we use grid in some places with the deprecated props. let me check whether or not we use some of these older pages, but we'd have to at least audit where we use grid

@mbarrramsey
Copy link
Contributor Author

Thanks @jwlee64! Can you share the page / link where we use Grid and I can try it out?

@mbarrramsey mbarrramsey merged commit 204ce1a into master Sep 9, 2024
25 checks passed
@mbarrramsey mbarrramsey deleted the mbarrramsey/upgrade_mui_version branch September 9, 2024 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants