-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(weave): autocomplete common component #2313
Merged
mbarrramsey
merged 10 commits into
master
from
mbarrramsey/autocomplete_common_component
Sep 9, 2024
Merged
chore(weave): autocomplete common component #2313
mbarrramsey
merged 10 commits into
master
from
mbarrramsey/autocomplete_common_component
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarrramsey
changed the base branch from
master
to
mbarrramsey/upgrade_mui_version
September 4, 2024 23:53
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=6ccd13ba7015792f87405857f25b6c0c8f3ca131 |
mbarrramsey
changed the base branch from
mbarrramsey/upgrade_mui_version
to
master
September 6, 2024 18:15
mbarrramsey
changed the base branch from
master
to
mbarrramsey/upgrade_mui_version
September 6, 2024 18:16
jwlee64
approved these changes
Sep 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autocomplete common component using mui, https://mui.com/material-ui/react-autocomplete/.
Depends on upgrading mui: #2308 in order to use a custom theme provider.
Example use case:
Screen.Recording.2024-09-06.at.10.32.43.AM.mov
Testing
How was this PR tested?