Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Refactor of Singlepass compiler to have better error and cpu features handling #3302

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Some Refactor of Singlepass compiler to have better error and cpu features handling #3302

merged 4 commits into from
Nov 22, 2022

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Nov 14, 2022 •
edited
Loading

Description

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner November 14, 2022 13:11
@ptitSeb ptitSeb requested a review from theduke November 14, 2022 15:31
@theduke
Copy link
Contributor

theduke commented Nov 15, 2022

I gave it a quick pass, but I don't have anything valuable to add.

@ptitSeb ptitSeb mentioned this pull request Nov 15, 2022
Closed
@ptitSeb
Copy link
Contributor Author

ptitSeb commented Nov 22, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

Build succeeded:

  • Code lint

@bors bors bot merged commit 0928629 into master Nov 22, 2022
@bors bors bot deleted the imp_singlepass_x86_64_tzcnt branch November 22, 2022 07:22
ptitSeb added a commit that referenced this pull request Nov 23, 2022
@ptitSeb
Added the actual LZCNT / TZCNT implementation, somehow missing from #…
23c67fd 
…3302
@ptitSeb ptitSeb mentioned this pull request Nov 23, 2022
Merged
bors bot added a commit that referenced this pull request Nov 24, 2022
@bors @ptitSeb
Merge #3364
c3ef0b7 
3364: Added the actual LZCNT / TZCNT implementation r=ptitSeb a=ptitSeb

# Description
The actual implementation of LZCNT and TZCNT for the x86_64 Singlepass backend.
Somehow, it was missing from #3302 

Co-authored-by: ptitSeb <sebastien.chev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptitSeb @theduke @syrusakbary