Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I was casually profiling
wasmi
and found that theValueStack
was particularly hot even though it has already seen many optimizations. So I took the chance and optimized it further given the invariants during bytecode execution.The results are approx. 10% performance improvement across the board.
The optimizations along the way:
ValueStack
.#[cold]
toUntypedError::invalid_len()
error constructor.local.{get,set,tee}
depth.{i32,i64}.{div,rem}
.