Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ValueStack #404

Merged
merged 7 commits into from
Aug 12, 2022
Merged

Optimize ValueStack #404

merged 7 commits into from
Aug 12, 2022

Commits on Aug 12, 2022

  1. optimize ValueStack methods by removing unncessary bounds checks 

    This resulted in a performance boost of approx 8-10% across the board.
In debug mode we still do bounds checking which helps with testing.
    @Robbepop
    Robbepop committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    df04051 View commit details
    Browse the repository at this point in the history

  2. optimize ValueStack::peek{_mut} slightly 

    No longer adds and subtracts depth by 1.
    @Robbepop
    Robbepop committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    90aec32 View commit details
    Browse the repository at this point in the history

  3. add #[cold] UntypedError::invalid_len and make use of it

    @Robbepop
    Robbepop committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    9b16e48 View commit details
    Browse the repository at this point in the history

  4. replace type name with Self in match

    @Robbepop
    Robbepop committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    f9d117b View commit details
    Browse the repository at this point in the history

  5. simplify and clean up impls for {i32,i64}::{div,rem}

    @Robbepop
    Robbepop committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    c015c2a View commit details
    Browse the repository at this point in the history

  6. fix compile error

    @Robbepop
    Robbepop committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    e6d5c45 View commit details
    Browse the repository at this point in the history

  7. apply rustfmt

    @Robbepop
    Robbepop committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    93ea23f View commit details
    Browse the repository at this point in the history