Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up inversion patching #260

Merged
merged 14 commits into from
Jul 31, 2024
Merged

speed up inversion patching #260

merged 14 commits into from
Jul 31, 2024

Conversation

ekg
Copy link
Collaborator

@ekg ekg commented Jul 23, 2024

Major speedup from capping the inverse patch alignment score with the score from the forward patch. In most cases, this is pretty good, leading to a short-circuit of the inverse patch. This gives a big speedup.

Second potential improvement: single patching round. Rationale: with BiWFA we don't need to stress about multiple rounds. We always patch global. @AndreaGuarracino if you have a test case showing the need for 2 rounds, lmk.

@ekg ekg merged commit 810bd0d into main Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant