-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix design implementation #6070
Fix design implementation #6070
Conversation
|
Test🟢 Go to the About page and compare it to the current About page. They must be the same. 🟢 When the bottom bar notification appears, check Disable update notifications and click the Dismiss button. Reload the page and check the network requests. A request for user preferences (ending in /me) should appear, but there should not be a request for available updates (ending in /updates?checkAvailableUpdates=false). 🟢 Go to Settings -> API configuration. Disable the network connection and click on Check Updates button. A toast should appear with an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEST:✔️
CR:✔️
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
36af078
into
enhancement/84-update-check-service-ui
Description
Issues Resolved
wazuh/wazuh-dashboard#96
Evidence
About page
Bottom bar notification
API Table
Updates status error message
Check updates button error
Test
Disable update notifications
and click theDismiss
button. Reload the page and check the network requests. A request for user preferences (ending in/me
) should appear, but there should not be a request for available updates (ending in/updates?checkAvailableUpdates=false
).Check Updates
button. A toast should appear with an error.Check List
yarn test:jest