Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix desing implementation #96

Closed
7 tasks done
Tracked by #84
lucianogorza opened this issue Aug 31, 2023 · 0 comments · Fixed by wazuh/wazuh-dashboard-plugins#6070
Closed
7 tasks done
Tracked by #84

Fix desing implementation #96

lucianogorza opened this issue Aug 31, 2023 · 0 comments · Fixed by wazuh/wazuh-dashboard-plugins#6070
Assignees
@lucianogorza
Labels
level/task Task issue type/enhancement New feature or request

Comments

@lucianogorza
Copy link

lucianogorza commented Aug 31, 2023 •
edited
Loading

Part of Epic
#84

Description

Implement the following changes to improve the solution.

Tasks

  • [Frontend Main Plugin] In the About page delete the API table and leave a React component the same as previous Angular template.
  • [Frontend Check Updates Plugin] Delete unused components related with About page.
  • [Frontend Check Updates Plugin] In the UpdatesNotification component only ask for available updates if user doesn't check "Disable update notifications".
  • [Frontend Main Plugin] In API Table handle check updates button errors and show toast.
  • [Frontend Main Plugin] In API Table show tooltip with the error message when status is "error".
  • [Frontend Main Plugin] Unit tests for new Flyout with updates details.
  • [Docker] Update WZ_HOME in README file.
@lucianogorza lucianogorza added type/enhancement New feature or request level/task Task issue labels Aug 31, 2023
@lucianogorza lucianogorza mentioned this issue Aug 31, 2023
Closed
15 tasks
@lucianogorza lucianogorza changed the title External check service for the plugin wazuh-check-updates Implement external check service for the plugin wazuh-check-updates Aug 31, 2023
@wazuhci wazuhci moved this to Backlog in Release 4.8.0 Aug 31, 2023
@lucianogorza lucianogorza changed the title Implement external check service for the plugin wazuh-check-updates Check integration with Wazuh API for available updates Oct 11, 2023
@lucianogorza lucianogorza self-assigned this Oct 20, 2023
@wazuhci wazuhci moved this from Backlog to In progress in Release 4.8.0 Oct 20, 2023
@wazuhci wazuhci moved this from In progress to On hold in Release 4.8.0 Oct 23, 2023
@lucianogorza lucianogorza linked a pull request Oct 25, 2023 that will close this issue
Check integration with Wazuh API for available updates wazuh/wazuh-dashboard-plugins#6036
Closed
6 tasks
@lucianogorza lucianogorza changed the title Check integration with Wazuh API for available updates Fix desing implementation Oct 26, 2023
@lucianogorza lucianogorza removed a link to a pull request Oct 26, 2023
Check integration with Wazuh API for available updates wazuh/wazuh-dashboard-plugins#6036
Closed
6 tasks
@wazuhci wazuhci moved this from On hold to In progress in Release 4.8.0 Oct 26, 2023
@lucianogorza lucianogorza mentioned this issue Oct 27, 2023
Merged
6 tasks
@lucianogorza lucianogorza linked a pull request Oct 27, 2023 that will close this issue
Fix design implementation wazuh/wazuh-dashboard-plugins#6070
Merged
6 tasks
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.8.0 Oct 30, 2023
@wazuhci wazuhci moved this from Pending review to Pending final review in Release 4.8.0 Oct 31, 2023
asteriscos added a commit to wazuh/wazuh-dashboard-plugins that referenced this issue Nov 2, 2023
@asteriscos
Fix design implementation (#6070)
36af078 
### Description
- In the About page delete the API table and leave a React component the
same as the previous Angular template.
-  Delete unused components related to the About page.
- In the UpdatesNotification component only ask for available updates if
the user doesn't check "Disable update notifications".
- In API Table handle check updates button errors and show a toast.
 
### Issues Resolved
wazuh/wazuh-dashboard#96

### Evidence

#### About page

![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/103193307/f63ef799-d74f-46b8-87c5-f9d5281c6e12)

#### Bottom bar notification

![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/103193307/5904fc9f-595c-4984-b898-c8ae8f555d6e)

#### API Table

![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/103193307/56f427c2-4d42-4caf-bdc1-c0ef0f56b9c2)

#### Updates status error message

![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/103193307/1fcfcd95-b4d5-460e-990c-799d1a11d294)

#### Check updates button error

![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/103193307/b6817794-30b7-49a0-9556-5f589ebde03e)

### Test

- Go to the About page and compare it to the current About page. They
must be the same.
- When the bottom bar notification appears, check `Disable update
notifications` and click the `Dismiss` button. Reload the page and check
the network requests. A request for user preferences (ending in `/me`)
should appear, but there should not be a request for available updates
(ending in `/updates?checkAvailableUpdates=false`).
- Go to Settings -> API configuration. Disable the network connection
and click on `Check Updates` button. A toast should appear with an
error.

### Check List
- [ ] All tests pass
  - [ ] `yarn test:jest`
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update [CHANGELOG.md](./../CHANGELOG.md)
- [ ] Commits are signed per the DCO using --signoff
@wazuhci wazuhci moved this from Pending final review to Done in Release 4.8.0 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucianogorza lucianogorza

Labels
level/task Task issue type/enhancement New feature or request
Projects
No open projects
Release 4.8.0
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix design implementation wazuh/wazuh-dashboard-plugins
1 participant
@lucianogorza