Left menu changes #6086
Merged
Left menu changes #6086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Nov 2, 2023
plugins/main/public/components/common/modules/overview-current-section.tsx
Show resolved
Hide resolved
Desvelao
reviewed
Nov 2, 2023
Desvelao
reviewed
Nov 2, 2023
Desvelao
reviewed
Nov 2, 2023
Desvelao
reviewed
Nov 2, 2023
Desvelao
reviewed
Nov 2, 2023
19 tasks
19 tasks
|
TestLegend: UI
Important🟡 The breadcrumb flickers and changes its state several times on each navigation. This should be fixed. Details 🟢 See the menu titles without camel case and the sub sections in camel case, in the breadcrumb it should look the same.Chrome - 🟢
🟢 The Home > Overview icon styles should be the same as those in the menu (test it in dark and light mode)Chrome - 🟢
🟢 Breadcrumb redirect well to the agentChrome - 🟢
🟢 In the agent view: The pinned applications should redirect to the respective application without reloading the page and if you hover it should show the url to which it redirects.Chrome - 🟢
🟢 In the agent view: When the menu is opened with the `More` button the options should redirect to the respective application without reloading the page and if hovered the url to which it redirects should appear.Chrome - 🟢
🟢 In the agent view: The Open MITRE ATT&CK button should redirect to the MITRE ATT&CK application without reloading the page and if hovered the url to which it redirects should appear.Chrome - 🟢
🟢 In the agent view: On the `FIM` card the icon should redirect to `FIM` without reloading the page and if hovered the url should appear.Chrome - 🟢
🟢 In the agent view: On the `SCA: last scan` card the icon should redirect to `SCA` without reloading the page and if the cursor is hovered over the url it redirects to should appear.Chrome - 🟢
🟢 In the agent view: On the `SCA: last scan` card the title should redirect to `SCA` without reloading the page and hovering over it should display the url it redirects to.Chrome - 🟢
🟢 In the agent view: On the `SCA: last scan` card The caption should redirect to `SCA` without reloading the page and if hovered over should display the url to which it redirects.Chrome - 🟢
🟢 In the overview: Without agents the `Add agent` button should redirect to the `Endpoint Summary` application without making a page reload and if hovered the url to which it redirects should appear.Chrome - 🟢
🟢 In the overview: The cards should redirect to their respective application without reloading the page and if you hover on the title you should see the url you are redirected to.Chrome - 🟢
🟢 In the healthcheck: The `Go to settings` button should redirect to the `Server APIs` application without reloading the page and if you hover it should show the url to which it redirects.Chrome - 🟢
🟢 - Applications with sample data: The button that takes you to sample data from the applications should redirect to the `Sample Data` application without making a page reload and if you hover it should appear the url to which it redirects.Chrome - 🟢
🟢 - In Endpoint Summary: The action buttons of the table should redirect to the `IT Hygiene` application without reloading the page and if hovered the url to which it redirects should appear.Chrome - 🟢
🟢 - In the configuration of an agent: The group buttons should redirect to the `Endpoint Groups` application without reloading the page and if hovered the url should be displayed.Chrome - 🟢
🟢 - In statistics: The `Settings` button should redirect to the `App Settings` application without a page reload and if hovered the url to which it redirects should appear.Chrome - 🟢
|
🟡 When clicking on cards or modules from the side menu the breadcrumb blinks and changes state several times per navigation. This should be fixed. Details 🟢 See the menu titles without camel case and the sub sections in camel case, in the breadcrumb it should look the same.Chrome - 🟢 
🟢 The Home > Overview icon styles should be the same as those in the menu (test it in dark and light mode)Chrome - 🟢 🟢 Breadcrumb redirect well to the agentChrome - 🟢 Grabacion.de.pantalla.2023-11-02.a.la.s.13.31.14.mov🟢 In the agent view: The pinned applications should redirect to the respective application without reloading the page and if you hover it should show the url to which it redirects.Chrome - 🟢 
🟢 In the agent view: When the menu is opened with the `More` button the options should redirect to the respective application without reloading the page and if hovered the url to which it redirects should appear.Chrome - 🟢 
🟢 In the agent view: The Open MITRE ATT&CK button should redirect to the MITRE ATT&CK application without reloading the page and if hovered the url to which it redirects should appear.Chrome - 🟢 
🟢 In the agent view: On the `FIM` card the icon should redirect to `FIM` without reloading the page and if hovered the url should appear.Chrome - 🟢 🟢 In the agent view: On the `SCA: last scan` card the icon should redirect to `SCA` without reloading the page and if the cursor is hovered over the url it redirects to should appear.Chrome - 🟢 🟢 In the agent view: On the `SCA: last scan` card the title should redirect to `SCA` without reloading the page and hovering over it should display the url it redirects to.Chrome - 🟢 
🟢 In the agent view: On the `SCA: last scan` card The caption should redirect to `SCA` without reloading the page and if hovered over should display the url to which it redirects.Chrome - 🟢 🟢 In the overview: Without agents the `Add agent` button should redirect to the `Endpoint Summary` application without making a page reload and if hovered the url to which it redirects should appear.Chrome - 🟢 
🟡 In the overview: The cards should redirect to their respective application without reloading the page and if you hover on the title you should see the url you are redirected to.Chrome - 🟡 When clicking on cards or modules from the side menu the breadcrumb blinks and changes state several times per navigation. This should be fixed. Grabacion.de.pantalla.2023-11-02.a.la.s.15.03.29.mov🟢 In the healthcheck: The `Go to settings` button should redirect to the `Server APIs` application without reloading the page and if you hover it should show the url to which it redirects.Chrome - 🟢 🟢 - Applications with sample data: The button that takes you to sample data from the applications should redirect to the `Sample Data` application without making a page reload and if you hover it should appear the url to which it redirects.Chrome - 🟢 🟢 - In Endpoint Summary: The action buttons of the table should redirect to the `IT Hygiene` application without reloading the page and if hovered the url to which it redirects should appear.Chrome - 🟢 
🟢 - In the configuration of an agent: The group buttons should redirect to the `Endpoint Groups` application without reloading the page and if hovered the url should be displayed.Chrome - 🟢 Grabacion.de.pantalla.2023-11-02.a.la.s.16.00.37.mov🟢 - In statistics: The `Settings` button should redirect to the `App Settings` application without a page reload and if hovered the url to which it redirects should appear.Chrome - 🟢 |
asteriscos
requested changes
Nov 2, 2023
chantal-kelm
reviewed
Nov 2, 2023
|
LGTM! |
The flick is caused due to the navigation between applications. This is happening with built-in applications too. |
asteriscos
approved these changes
Nov 3, 2023
asteriscos
merged commit 960af00
into
feat/83-move-menu-items-to-applications
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes in the left menu order
Change of styles in Home > Overview
Changed left menu and breadcrumbs names
Redirects were changed so that it does not refresh the page and to have it centralized in the applications file.
Issues Resolved
Evidence
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Morebutton the options should redirect to the respective application without reloading the page and if hovered the url to which it redirects should appear.FIMcard the icon should redirect toFIMwithout reloading the page and if hovered the url should appear.SCA: last scancard the icon should redirect toSCAwithout reloading the page and if the cursor is hovered over the url it redirects to should appear.SCA: last scancard the title should redirect toSCAwithout reloading the page and hovering over it should display the url it redirects to.SCA: last scancard The caption should redirect toSCAwithout reloading the page and if hovered over should display the url to which it redirects.Add agentbutton should redirect to theEndpoint Summaryapplication without making a page reload and if hovered the url to which it redirects should appear.Go to settingsbutton should redirect to theServer APIsapplication without reloading the page and if you hover it should show the url to which it redirects.Sample Dataapplication without making a page reload and if you hover it should appear the url to which it redirects.IT Hygieneapplication without reloading the page and if hovered the url to which it redirects should appear.Endpoint Groupsapplication without reloading the page and if hovered the url should be displayed.Settingsbutton should redirect to theApp Settingsapplication without a page reload and if hovered the url to which it redirects should appear.Details
⚫ See the menu titles without camel case and the sub sections in camel case, in the breadcrumb it should look the same.
Chrome - ⚫
⚫ The Home > Overview icon styles should be the same as those in the menu (test it in dark and light mode)
Chrome - ⚫
⚫ Breadcrumb redirect well to the agent
Chrome - ⚫
⚫ In the agent view: The pinned applications should redirect to the respective application without reloading the page and if you hover it should show the url to which it redirects.
Chrome - ⚫
⚫ In the agent view: When the menu is opened with the `More` button the options should redirect to the respective application without reloading the page and if hovered the url to which it redirects should appear.
Chrome - ⚫
⚫ In the agent view: The Open MITRE ATT&CK button should redirect to the MITRE ATT&CK application without reloading the page and if hovered the url to which it redirects should appear.
Chrome - ⚫
⚫ In the agent view: On the `FIM` card the icon should redirect to `FIM` without reloading the page and if hovered the url should appear.
Chrome - ⚫
⚫ In the agent view: On the `SCA: last scan` card the icon should redirect to `SCA` without reloading the page and if the cursor is hovered over the url it redirects to should appear.
Chrome - ⚫
⚫ In the agent view: On the `SCA: last scan` card the title should redirect to `SCA` without reloading the page and hovering over it should display the url it redirects to.
Chrome - ⚫
⚫ In the agent view: On the `SCA: last scan` card The caption should redirect to `SCA` without reloading the page and if hovered over should display the url to which it redirects.
Chrome - ⚫
⚫ In the overview: Without agents the `Add agent` button should redirect to the `Endpoint Summary` application without making a page reload and if hovered the url to which it redirects should appear.
Chrome - ⚫
⚫ In the overview: The cards should redirect to their respective application without reloading the page and if you hover on the title you should see the url you are redirected to.
Chrome - ⚫
⚫ In the healthcheck: The `Go to settings` button should redirect to the `Server APIs` application without reloading the page and if you hover it should show the url to which it redirects.
Chrome - ⚫
⚫ - Applications with sample data: The button that takes you to sample data from the applications should redirect to the `Sample Data` application without making a page reload and if you hover it should appear the url to which it redirects.
Chrome - ⚫
⚫ - In Endpoint Summary: The action buttons of the table should redirect to the `IT Hygiene` application without reloading the page and if hovered the url to which it redirects should appear.
Chrome - ⚫
⚫ - In the configuration of an agent: The group buttons should redirect to the `Endpoint Groups` application without reloading the page and if hovered the url should be displayed.
Chrome - ⚫
⚫ - In statistics: The `Settings` button should redirect to the `App Settings` application without a page reload and if hovered the url to which it redirects should appear.
Chrome - ⚫
Check List
yarn test:jest