Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate our menu into the platform global navigation drawer #94

Closed
18 of 19 tasks
Tracked by #83
AlexRuiz7 opened this issue Aug 30, 2023 · 3 comments · Fixed by wazuh/wazuh-dashboard-plugins#6086 or wazuh/wazuh-packages#2578
Closed
18 of 19 tasks
Tracked by #83

Integrate our menu into the platform global navigation drawer #94

AlexRuiz7 opened this issue Aug 30, 2023 · 3 comments · Fixed by wazuh/wazuh-dashboard-plugins#6086 or wazuh/wazuh-packages#2578
Assignees
@Desvelao @yenienserrano @JuanGarriuz
Labels
level/epic type/change Change performed in a Wazuh Cloud environment issue

Comments

@AlexRuiz7
Copy link
Member

AlexRuiz7 commented Aug 30, 2023 •
edited by yenienserrano
Loading

Description

In this issue, we'll track the progress to implement the selected design (see #93) to integrate Wazuh's app menu into the platform's navigation drawer menu.

Design

See selected design in:

Requirements

See requirements in:

Tasks
@AlexRuiz7 AlexRuiz7 mentioned this issue Aug 30, 2023
Closed
3 tasks
@AlexRuiz7 AlexRuiz7 added level/epic type/change Change performed in a Wazuh Cloud environment issue labels Aug 30, 2023
@wazuhci wazuhci moved this to In progress in Release 4.8.0 Aug 30, 2023
@Desvelao
Copy link
Member

Desvelao commented Sep 1, 2023

Branching strategy

image

@wazuhci wazuhci moved this from In progress to On hold in Release 4.8.0 Sep 12, 2023
@yenienserrano
Copy link
Member

With the new OSD 2.10.0 update the breadcrumb has been updated and needs to be updated.

image

@yenienserrano
Copy link
Member

yenienserrano commented Oct 4, 2023 •
edited
Loading

We need to fix the redirection of an agent to some group as it has to redirect to the groups plugin and is trying to go to endpoint-group.

https://github.com/wazuh/wazuh-kibana-app/blob/feat/83-move-menu-items-to-applications/plugins/main/public/components/common/util/agent-group-truncate/group-truncate.tsx#L55

https://github.com/wazuh/wazuh-kibana-app/blob/feat/83-move-menu-items-to-applications/plugins/main/public/controllers/management/components/management/configuration/configuration-switch.js#L214

Details

image
image
image

In the Statistics plugin the same thing is happening with the settings button, it redirects to a wazuh-plugin-settings and should redirect to settings.

https://github.com/wazuh/wazuh-dashboard-plugins/blob/feat/83-move-menu-items-to-applications/plugins/main/public/controllers/management/components/management/statistics/statistics-overview.js#L203

Details

image
image

is added in this issue

@Desvelao Desvelao linked a pull request Oct 20, 2023 that will close this issue
Add an agent selector to IT Hygiene application wazuh/wazuh-dashboard-plugins#6005
Merged
6 tasks
@Desvelao Desvelao removed a link to a pull request Oct 20, 2023
Add an agent selector to IT Hygiene application wazuh/wazuh-dashboard-plugins#6005
Merged
6 tasks
@rauldpm rauldpm mentioned this issue Oct 24, 2023
Closed
13 tasks
@wazuhci wazuhci moved this from On hold to In progress in Release 4.8.0 Oct 27, 2023
This was referenced Nov 1, 2023
Closed
Merged
@Desvelao Desvelao linked a pull request Nov 2, 2023 that will close this issue
Left menu changes wazuh/wazuh-dashboard-plugins#6086
Merged
6 tasks
@Desvelao Desvelao mentioned this issue Nov 3, 2023
Merged
30 tasks
@Desvelao Desvelao linked a pull request Nov 3, 2023 that will close this issue
Change the order of Explore category and Indexer/dashboard management title on dashboard wazuh/wazuh-packages#2578
Merged
30 tasks
asteriscos added a commit to wazuh/wazuh-dashboard-plugins that referenced this issue Nov 3, 2023
@asteriscos
Left menu changes (#6086)
960af00 
### Description

Changes in the left menu order
Change of styles in Home > Overview
Changed left menu and breadcrumbs names
Redirects were changed so that it does not refresh the page and to have
it centralized in the applications file.
 
### Issues Resolved

- wazuh/wazuh-dashboard#94

### Evidence


![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/63758389/6915bad3-2a30-4313-9ddf-409a3ff1ba66)

![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/63758389/140ef5ad-7f89-4ddf-8f23-d8ec870888dc)

![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/63758389/b7b5fd51-17e3-4a6a-a990-621ff9f86a48)


### Test

Legend:
:black_circle:: none
:green_circle:: pass
:yellow_circle:: warning
:red_circle:: fail
:white_circle:: not applicable

## UI

| Test | Chrome |
| --- |  --- |
| See the menu titles without camel case and the sub sections in camel
case, in the breadcrumb it should look the same.| :black_circle: |
| The Home > Overview icon styles should be the same as those in the
menu (test it in dark and light mode) | :black_circle: |
| Breadcrumb redirect well to the agent | :black_circle: |
| In the agent view: The pinned applications should redirect to the
respective application without reloading the page and if you hover it
should show the url to which it redirects. | :black_circle: |
| In the agent view: When the menu is opened with the `More` button the
options should redirect to the respective application without reloading
the page and if hovered the url to which it redirects should appear. |
:black_circle: |
| In the agent view: The Open MITRE ATT&CK button should redirect to the
MITRE ATT&CK application without reloading the page and if hovered the
url to which it redirects should appear. | :black_circle: |
| In the agent view: On the `FIM` card the icon should redirect to `FIM`
without reloading the page and if hovered the url should appear. |
:black_circle: |
| In the agent view: On the `SCA: last scan` card the icon should
redirect to `SCA` without reloading the page and if the cursor is
hovered over the url it redirects to should appear. | :black_circle: |
| In the agent view: On the `SCA: last scan` card the title should
redirect to `SCA` without reloading the page and hovering over it should
display the url it redirects to. | :black_circle: |
| In the agent view: On the `SCA: last scan` card The caption should
redirect to `SCA` without reloading the page and if hovered over should
display the url to which it redirects. | :black_circle: |
| In the overview: Without agents the `Add agent` button should redirect
to the `Endpoint Summary` application without making a page reload and
if hovered the url to which it redirects should appear. | :black_circle:
|
| In the overview: The cards should redirect to their respective
application without reloading the page and if you hover on the title you
should see the url you are redirected to. | :black_circle: |
| In the healthcheck: The `Go to settings` button should redirect to the
`Server APIs` application without reloading the page and if you hover it
should show the url to which it redirects. | :black_circle: |
| Applications with sample data: The button that takes you to sample
data from the applications should redirect to the `Sample Data`
application without making a page reload and if you hover it should
appear the url to which it redirects. | :black_circle: |
| In Endpoint Summary: The action buttons of the table should redirect
to the `IT Hygiene` application without reloading the page and if
hovered the url to which it redirects should appear. | :black_circle: |
| In the configuration of an agent: The group buttons should redirect to
the `Endpoint Groups` application without reloading the page and if
hovered the url should be displayed. | :black_circle: |
| In statistics: The `Settings` button should redirect to the `App
Settings` application without a page reload and if hovered the url to
which it redirects should appear. | :black_circle: |


**Details**
<details>
<summary>:black_circle: See the menu titles without camel case and the
sub sections in camel case, in the breadcrumb it should look the same.
</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: The Home > Overview icon styles should be the
same as those in the menu (test it in dark and light mode)</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: Breadcrumb redirect well to the agent</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the agent view: The pinned applications
should redirect to the respective application without reloading the page
and if you hover it should show the url to which it redirects.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the agent view: When the menu is opened with
the `More` button the options should redirect to the respective
application without reloading the page and if hovered the url to which
it redirects should appear.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the agent view: The Open MITRE ATT&CK button
should redirect to the MITRE ATT&CK application without reloading the
page and if hovered the url to which it redirects should
appear.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the agent view: On the `FIM` card the icon
should redirect to `FIM` without reloading the page and if hovered the
url should appear.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the agent view: On the `SCA: last scan` card
the icon should redirect to `SCA` without reloading the page and if the
cursor is hovered over the url it redirects to should appear.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the agent view: On the `SCA: last scan` card
the title should redirect to `SCA` without reloading the page and
hovering over it should display the url it redirects to.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the agent view: On the `SCA: last scan` card
The caption should redirect to `SCA` without reloading the page and if
hovered over should display the url to which it redirects.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the overview: Without agents the `Add agent`
button should redirect to the `Endpoint Summary` application without
making a page reload and if hovered the url to which it redirects should
appear.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the overview: The cards should redirect to
their respective application without reloading the page and if you hover
on the title you should see the url you are redirected to.
</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: In the healthcheck: The `Go to settings` button
should redirect to the `Server APIs` application without reloading the
page and if you hover it should show the url to which it
redirects.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: - Applications with sample data: The button that
takes you to sample data from the applications should redirect to the
`Sample Data` application without making a page reload and if you hover
it should appear the url to which it redirects.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: - In Endpoint Summary: The action buttons of the
table should redirect to the `IT Hygiene` application without reloading
the page and if hovered the url to which it redirects should
appear.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: - In the configuration of an agent: The group
buttons should redirect to the `Endpoint Groups` application without
reloading the page and if hovered the url should be displayed.</summary>

Chrome - :black_circle:

</details>

<details>
<summary>:black_circle: - In statistics: The `Settings` button should
redirect to the `App Settings` application without a page reload and if
hovered the url to which it redirects should appear.</summary>

Chrome - :black_circle:

</details>






### Check List
- [ ] All tests pass
  - [ ] `yarn test:jest`
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update [CHANGELOG.md](./../CHANGELOG.md)
- [x] Commits are signed per the DCO using --signoff
@gdiazlo gdiazlo closed this as completed Nov 8, 2023
@wazuhci wazuhci moved this from In progress to Done in Release 4.8.0 Nov 8, 2023
@asteriscos asteriscos mentioned this issue Dec 14, 2023
Closed
1 task
@yenienserrano yenienserrano mentioned this issue Dec 21, 2023
Merged
6 tasks
@asteriscos asteriscos mentioned this issue Jan 12, 2024
Closed
1 task
@lucianogorza lucianogorza mentioned this issue Feb 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Desvelao Desvelao

@yenienserrano yenienserrano

@JuanGarriuz JuanGarriuz

Labels
level/epic type/change Change performed in a Wazuh Cloud environment issue
Projects
No open projects
Release 4.8.0
Archived in project
Milestone
No milestone
5 participants
@gdiazlo @AlexRuiz7 @Desvelao @yenienserrano @JuanGarriuz