-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate AngularJS routing to React #6689
Conversation
- Create basic router - Remove initilization of AngularJS app - Replace AngularJS injector usage by ReactJS
- Create route resolvers - ip - wzConfig - Adapt components to the usage of route resolvers - Fix an error related to circular dependency
- Port route resolvers - getSavedSearch - nestedResolve - savedSearch
- WzAgentSelectorWrapper - ToastNotificationsModal - WzUpdatesNotification
…zuh/wazuh-kibana-app into feat/6680-migrate-app-routing
- useRootScope hook - withModuleTabLoader HOC - Dashboard component
- VisFactoryHandler
- Remove AngularJS services: - DiscoverPendingUpdates - LoadedVisualizations - RawVisualizations - VisHandlers - Remove components: - KibanaVis - ClusterTimelions - KibanaVisWrapper - Metrics - WzVisualize - WzFilterBar
- Remove components - SecurityAlerts
- Redux actions and reducers related to deprecated visualizations
CR 🟢Test 🟡
Details 🟢 Check that all menus in the menu bar redirect correctly.Chrome - 🟢 menu-route.webmFirefox - ⚫ Safari - ⚫ 🟢 In Overview, check that the panels redirect to the different modules correctly. Also the links to the "AGENTS SUMMARY" visualization and the "LAST 24 HOURS ALERTS" KPIs.Chrome - 🟢 Agents Summaryagents-summary.webmLas 24 hs alertslas-24hs-alerts.webmEndpoint Securityendpoint-security.webmThreat Intelligencethreat-intelligence.webmSecuriry Operationssecurity-operation.webmCloud Securitycloud-security.webmFirefox - ⚫ Safari - ⚫ 🟢 In each module, check, if applicable, that the different tabs work correctly.Chrome - 🟢 Configuration AssessmentMalware DetectionFIMThreat HuntingVulnerability DetectionMittre Att&ctVirusTotalPCIGDPRHIPAANISTTCSDockerAWSGoogle CloudGitHubOffice 365Firefox - ⚫ Safari - ⚫ 🟢 In the corresponding modules, check the operation of the pinned agent.Chrome - 🟢 pinned-agent.webmFirefox - ⚫ Safari - ⚫ 🟢 Check on the screens where the searchBar exists the correct functioning of the filters, both entered through the searchBar and through interaction with visualizations.Chrome - 🟢 searchbar.webmFirefox - ⚫ Safari - ⚫ 🟢 Check on the screens where tables exist, any onclick functionality of the rows, as well as links, if applicable.Chrome - 🟢 table-links.webmFirefox - ⚫ Safari - ⚫ 🟢 Check the correct operation of the API change.Chrome - 🟢 api-change.webmFirefox - ⚫ Safari - ⚫ 🟢 Check the correct operation of the index pattern change.Chrome - 🟢 index-pattern-change.webmFirefox - ⚫ Safari - ⚫ 🟢 Check where appropriate the correct functioning of the flyouts, as well as the links present therein.Chrome - 🟢 table-links.webmFirefox - ⚫ Safari - ⚫ 🟡 While testing the previous points, try using the browser's backward and forward redirection. Also check that the URL is updated correctly.Chrome - 🟡 After loading the Dashboard pages, when you press then back button, the url only removes the filters but remains on the same page. previous-page.webmFirefox - ⚫ Safari - ⚫ |
CR ⚫Test ⚫
Details 🟢 Check that all menus in the menu bar redirect correctly.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 Grabacion.de.pantalla.2024-06-11.a.la.s.10.57.41.a.m.movGrabacion.de.pantalla.2024-06-11.a.la.s.11.14.09.a.m.mov🟢 Check the correct operation of the breadcrumbs.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 Some of the tests carried out:Grabacion.de.pantalla.2024-06-11.a.la.s.11.25.10.a.m.mov🟢 In Overview, check that the panels redirect to the different modules correctly. Also the links to the "AGENTS SUMMARY" visualization and the "LAST 24 HOURS ALERTS" KPIs.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 Grabacion.de.pantalla.2024-06-11.a.la.s.1.19.10.p.m.movGrabacion.de.pantalla.2024-06-11.a.la.s.1.24.32.p.m.mov🟢 In each module, check, if applicable, that the different tabs work correctly.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 Grabacion.de.pantalla.2024-06-11.a.la.s.1.30.48.p.m.mov🟢 In the corresponding modules, check the operation of the pinned agent.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 Grabacion.de.pantalla.2024-06-11.a.la.s.1.32.43.p.m.mov🟢 Check on the screens where the searchBar exists the correct functioning of the filters, both entered through the searchBar and through interaction with visualizations.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 Grabacion.de.pantalla.2024-06-11.a.la.s.1.36.23.p.m.mov🟢 Check on the screens where tables exist, any onclick functionality of the rows, as well as links, if applicable.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ Grabacion.de.pantalla.2024-06-11.a.la.s.1.39.13.p.m.movGrabacion.de.pantalla.2024-06-11.a.la.s.1.44.39.p.m.mov🔴 Check the correct operation of the API change.Chrome - ⚫ Firefox - ⚫ Safari - 🔴 Grabacion.de.pantalla.2024-06-11.a.la.s.1.50.52.p.m.mov🟢 Check the correct operation of the index pattern change.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 Grabacion.de.pantalla.2024-06-11.a.la.s.2.27.13.p.m.mov🟢 Check where appropriate the correct functioning of the flyouts, as well as the links present therein.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 Grabacion.de.pantalla.2024-06-11.a.la.s.2.08.55.p.m.mov🟡 While testing the previous points, try using the browser's backward and forward redirection. Also check that the URL is updated correctly.Chrome - ⚫ Firefox - ⚫ Safari - 🟡 In some cases the back button does not work: Grabacion.de.pantalla.2024-06-11.a.la.s.11.54.37.a.m.mov |
With sample data you navigate from events to some agent that doesn't exist when you go back to the dashboards, the view loads fine but the breadcrumb doesn't change and the error view appears below the graphs. Screen.Recording.2024-06-10.at.10.27.49.PM.mov |
TestLegend: Note Due to the magnitude of the change that this PR implies, it is necessary to test the entire application, not just limit yourself to the general points shown below:
Details 🟢 Check that all menus in the menu bar redirect correctly.Chrome - 🟢 Grabacion.2024-06-11.120307.mp4Firefox - ⚫ Safari - ⚫ 🟢 Check the correct operation of the breadcrumbs.Chrome - 🟢 Grabacion.2024-06-11.120307.mp4Firefox - ⚫ Safari - ⚫ 🟢 In Overview, check that the panels redirect to the different modules correctly. Also the links to the "AGENTS SUMMARY" visualization and the "LAST 24 HOURS ALERTS" KPIs.Chrome - 🟢 Grabacion.2024-06-11.120307.mp4Firefox - ⚫ Safari - ⚫ 🟢 In each module, check, if applicable, that the different tabs work correctly.Chrome - 🟢 Grabacion.2024-06-11.123352.mp4Firefox - ⚫ Safari - ⚫ ⚫ In the corresponding modules, check the operation of the pinned agent.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ Check on the screens where the searchBar exists the correct functioning of the filters, both entered through the searchBar and through interaction with visualizations.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ Check on the screens where tables exist, any onclick functionality of the rows, as well as links, if applicable.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ 🟢 Check the correct operation of the API change.Chrome - 🟢 Grabacion.2024-06-11.123352.mp4Firefox - ⚫ Safari - ⚫ ⚫ Check the correct operation of the index pattern change.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ Check where appropriate the correct functioning of the flyouts, as well as the links present therein.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ 🟡 While testing the previous points, try using the browser's backward and forward redirection. Also check that the URL is updated correctly.The Chrome - 🟡 Grabacion.2024-06-11.123352.mp4Firefox - ⚫ Safari - ⚫ |
EvidenceEvidence.webmTestLegend: Note Due to the magnitude of the change that this PR implies, it is necessary to test the entire application, not just limit yourself to the general points shown below:
Details 🟢 Check that all menus in the menu bar redirect correctly.Chrome - 🟢 Screen.Recording.2024-06-11.at.10.58.14.movScreen.Recording.2024-06-11.at.11.00.23.movFirefox - ⚫ Safari - ⚫ 🟢 Check the correct operation of the breadcrumbs.Chrome - 🟢 Screen.Recording.2024-06-11.at.11.22.13.movFirefox - ⚫ Safari - ⚫ 🟢 In Overview, check that the panels redirect to the different modules correctly. Also the links to the "AGENTS SUMMARY" visualization and the "LAST 24 HOURS ALERTS" KPIs.Chrome - 🟢 Screen.Recording.2024-06-11.at.11.29.39.movFirefox - ⚫ Safari - ⚫ ⚫ In each module, check, if applicable, that the different tabs work correctly.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ In the corresponding modules, check the operation of the pinned agent.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ Check on the screens where the searchBar exists the correct functioning of the filters, both entered through the searchBar and through interaction with visualizations.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ Check on the screens where tables exist, any onclick functionality of the rows, as well as links, if applicable.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ Check the correct operation of the API change.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ Check the correct operation of the index pattern change.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ Check where appropriate the correct functioning of the flyouts, as well as the links present therein.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ ⚫ While testing the previous points, try using the browser's backward and forward redirection. Also check that the URL is updated correctly.Chrome - ⚫ Firefox - ⚫ Safari - ⚫ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
|
Description
This pull request migrates the AngularJS routing to React.
Changes:
Clean changes (changes not related to routing issue):
QOL changes:
tab
parameter value to render the dashboard. It usesdashboard
instead ofpanels
ordashboard
window.location
to navigate or getting values from the URLIssues Resolved
#6680
Evidence
Evidence.webm
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
Note
Due to the magnitude of the change that this PR implies, it is necessary to test the entire application, not just limit yourself to the general points shown below:
Details
⚫ Check that all menus in the menu bar redirect correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check the correct operation of the breadcrumbs.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Overview, check that the panels redirect to the different modules correctly. Also the links to the "AGENTS SUMMARY" visualization and the "LAST 24 HOURS ALERTS" KPIs.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In each module, check, if applicable, that the different tabs work correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In the corresponding modules, check the operation of the pinned agent.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check on the screens where the searchBar exists the correct functioning of the filters, both entered through the searchBar and through interaction with visualizations.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check on the screens where tables exist, any onclick functionality of the rows, as well as links, if applicable.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check the correct operation of the API change.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check the correct operation of the index pattern change.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check where appropriate the correct functioning of the flyouts, as well as the links present therein.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ While testing the previous points, try using the browser's backward and forward redirection. Also check that the URL is updated correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest