Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change location of I18nProvider #6723

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented May 29, 2024

Description

Move the I18nProvider so that it is wrapping the whole view and is only 1 element (EuiPage).

Issues Resolved

Evidence

Screen.Recording.2024-05-29.at.9.09.16.PM.mov

Test

  1. Navigate to Server Management > Statistics
  2. Check that the error does not appear in the console
    Failed prop type: Invalid prop children of type array supplied to PseudoLocaleWrapper, expected a single ReactElement.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano linked an issue May 29, 2024 that may be closed by this pull request
15 tasks
@yenienserrano yenienserrano mentioned this pull request May 29, 2024
15 tasks
@yenienserrano yenienserrano self-assigned this May 29, 2024
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Peek 2024-05-30 11-44

@yenienserrano
Copy link
Member Author

This issue is closed in favor of this one #6689

@yenienserrano yenienserrano deleted the fix/6693-Invalid-prop-children-of-type-array-supplied-to-PseudoLocaleWrapper branch May 30, 2024 14:02
@jbiset jbiset mentioned this pull request Jun 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings and errors in console
2 participants