Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statistics analysis engine dashboard queue usage is misleading #7192

Merged
merged 17 commits into from
Dec 11, 2024
Merged

Statistics analysis engine dashboard queue usage is misleading #7192

merged 17 commits into from
Dec 11, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Dec 3, 2024 •
edited
Loading

Description

Currently, the analysis engine queue usage visualizations display not only the absolute value of the amount of decoded events, but also shows the queue usage percentages. Using the same visualization to display both values has proven to be misleading, therefore we have to design and propose a better and easier-to-understand way to show the percentages of the events queue usage.

Issues Resolved

Closes #7181

Evidence

image

Test

  1. Navigate to Server management » Statistics.
  2. Select the Analysis Engine tab.
  3. Check the following visualizations:
    • Syscheck
    • Syscollector
    • Rootcheck
    • SCA
    • Host Info

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli
Enhance dashboard panels: update line widths, add valueAxis settings,…
58ecb06 
… and clean unused metrics for improved clarity
@guidomodarelli
Refactor dashboard panels: remove unused properties and update data c…
57f1589 
…onfigurations for better visualization and clarity
@guidomodarelli
Update dashboard panel configurations: disable defaultYExtents, reint…
b7269a6 
…roduce avg metric for queue usage with optimized script
@guidomodarelli
Disable avg metrics for syscheck, syscollector, and rootcheck in dash…
18419de 
…board panels for more accurate data representation
@guidomodarelli
Update dashboard panel settings: disable defaultYExtents and re-add a…
0c9b8f1 
…vg metric for queue usage with cleared script configuration
@guidomodarelli
Modify dashboard settings: set lineWidth to 4, clear json configs, re…
6c5379b 
…introduce avg metric for queue usage, and adjust axes
@guidomodarelli
Enable avg metrics for syscheck, syscollector, and rootcheck in dashb…
c50e7bf 
…oard panels to enhance data visibility and analysis
@guidomodarelli
Refactor dashboard panel values to dynamically calculate using 16384 …
decec68 
…* 0.9 for improved accuracy in visualizations
@guidomodarelli
Update dashboard panel scripts for queue usage to simplify calculatio…
bfccca1 
…n and enhance readability in visualizations
@guidomodarelli
Refactor dashboard panel threshold settings to hide lines and use fix…
6ad4fda 
…ed values for improved visualization clarity and accuracy
@guidomodarelli
Add max metric for syscheck_queue_size in dashboard panels to enhance…
a602e05 
… analysis and improve visualization clarity
@guidomodarelli
Update dashboard panel Y-axis settings to enable default extents and …
429e179 
…improve visualization accuracy across multiple components
@guidomodarelli
Enhance dashboard panel scale settings by ensuring consistent Y-axis …
a025828 
…limits for accurate data representation across components
@chantal-kelm chantal-kelm self-requested a review December 4, 2024 18:05
chantal-kelm
chantal-kelm previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de pantalla 2024-12-04 a la(s) 6 41 03 p  m Captura de pantalla 2024-12-04 a la(s) 6 40 56 p  m

@yenienserrano yenienserrano linked an issue Dec 5, 2024 that may be closed by this pull request
Statistics analysis engine dashboard queue usage is misleading #7181
Closed
1 task
@guidomodarelli
Refine queue usage visualizations in Statistics for improved clarity …
52b7679 
…and accuracy in dashboard data representation
guidomodarelli and others added 3 commits December 10, 2024 10:21
@guidomodarelli
Merge branch '4.10.2' into enhancement/7181-statistics-analysis-engin…
78612d5 
…e-dashboard-queue-usage-is-misleading
@guidomodarelli
Increase line width in analysis engine dashboard for better visibilit…
09aa0c2 
…y and clarity in data visualizations
@guidomodarelli
Refine queue usage visualizations in Statistics section of CHANGELOG …
404bf08 
…for improved clarity and consistency in project documentation
asteriscos
asteriscos approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 15.23% ( 4534 / 29766 )
Branches 10.07% ( 1942 / 19284 )
Functions 15.16% ( 1089 / 7183 )
Lines 15.44% ( 4423 / 28635 )

@chantal-kelm chantal-kelm self-requested a review December 11, 2024 13:27
chantal-kelm
chantal-kelm approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Captura de pantalla 2024-12-11 a la(s) 10 37 26 a  m

@asteriscos asteriscos merged commit 8a128e9 into 4.10.2 Dec 11, 2024
5 of 6 checks passed
@asteriscos asteriscos deleted the enhancement/7181-statistics-analysis-engine-dashboard-queue-usage-is-misleading branch December 11, 2024 14:32
@chantal-kelm chantal-kelm mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Statistics analysis engine dashboard queue usage is misleading
3 participants
@guidomodarelli @asteriscos @chantal-kelm