Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error on the Agents main view #4233

Merged
merged 8 commits into from
Jun 13, 2022

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Jun 8, 2022

Steps to reproduce

1- Navigate to an Agent's view.
2- Resize your browser's window.
3 - Open the browser's console.
4 - Navigate to the Inventory Data section.
5 - See the error.

Video where you see the error solved:
https://user-images.githubusercontent.com/99441266/172658878-3eb21f0c-61d8-410a-a6f3-862d96fdf923.mp4

Closes #4158

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️

Peek.09-06-2022.12-39.mp4

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅
Test ✅

@AlexRuiz7 AlexRuiz7 changed the title Fix/4158 type error agents main view Fix type error on the Agents main view Jun 13, 2022
@AlexRuiz7 AlexRuiz7 merged commit 7536c05 into 4.3-7.10 Jun 13, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/4158-TypeError-Agents-main-view branch June 13, 2022 15:29
@AlexRuiz7 AlexRuiz7 restored the fix/4158-TypeError-Agents-main-view branch June 13, 2022 15:33
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.09% ( 1489 / 36383 )
Branches 1.67% ( 473 / 28242 )
Functions 3.06% ( 272 / 8897 )
Lines 4.14% ( 1440 / 34801 )

@github-actions
Copy link
Contributor

The backport to 4.3-1.2-wzd failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4233-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7536c05a7986d55a4435eb42bfbd8a8b39733984
# Push it to GitHub
git push --set-upstream origin backport-4233-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzd

Then, create a pull request where the base branch is 4.3-1.2-wzd and the compare/head branch is backport-4233-to-4.3-1.2-wzd.

@github-actions
Copy link
Contributor

The backport to 4.3-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-7.16 4.3-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.3-7.16
# Create a new branch
git switch --create backport-4233-to-4.3-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7536c05a7986d55a4435eb42bfbd8a8b39733984
# Push it to GitHub
git push --set-upstream origin backport-4233-to-4.3-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-7.16

Then, create a pull request where the base branch is 4.3-7.16 and the compare/head branch is backport-4233-to-4.3-7.16.

AlexRuiz7 pushed a commit that referenced this pull request Jun 13, 2022
* Update CHANGELOG.md

* Update kibana-vis.js

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 7536c05)
AlexRuiz7 pushed a commit that referenced this pull request Jun 13, 2022
* Update CHANGELOG.md

* Update kibana-vis.js

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 7536c05)
AlexRuiz7 added a commit that referenced this pull request Jun 13, 2022
* Update CHANGELOG.md

* Update kibana-vis.js

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 7536c05)

Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>
AlexRuiz7 added a commit that referenced this pull request Jun 13, 2022
* Update CHANGELOG.md

* Update kibana-vis.js

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 7536c05)

Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>
@AlexRuiz7 AlexRuiz7 deleted the fix/4158-TypeError-Agents-main-view branch June 13, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: cannot read properties of undefined on the main Agents view
4 participants