-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit urllib3 major required version #4162
Conversation
c41a96c
to
56763d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The change itself it is not breaking as it is only used in two modules that are currently deprecated:
- qa_docs.py
- api_simulator.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
urllib3
is not only imported with:
import urllib3
It can also be from
. If we look for this, several tests are affected, since it is used to disable warnings for API requests. This affects e2e tests, api tests, authd tests, logcollector tests and remoted tests. Please, let's run these tests to make 100% sure that there is no problem.
Update@Rebits launch the IT launcher tests on this branch and went well https://ci.wazuh.info/job/Test_integration_launcher/137 As @juliamagan mentioned, we will work on testing on every possible affected test |
LGTM |
TIs have been found to be stable with this change.
Limit urllib3 major required version
Description
Repository
requirements.txt
request urllib3>=1.26.5, but since April 26 2023 urllib3 2.0.0 was released having breaking changes like urllib3/urllib3#2168 that not only have impact on our Jenkins CICD pipelines/envs but could break our IT any minute.Updated
urllib3
major version to be lower than2
Testing performed
FIM IT on macOS and Solaris went well https://ci.wazuh.info/job/Test_integration/38516/ 🟢