Limit urllib3 major required version - to 4.5 #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebits
approved these changes
May 16, 2023
jnasselle
force-pushed
the
5074-limit-urllib3-required-version-to4.5
branch
from
090f118 to
fb103d3
Compare
jnasselle
added a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Repository
requirements.txtrequest urllib3>=1.26.5, but since April 26 2023 urllib3 2.0.0 was released having breaking changes like urllib3/urllib3#2168 that not only have impact on our Jenkins CICD pipelines/envs but could break our IT any minute.Updated
urllib3major version to be lower than2Testing performed
This was tested during original testing pointing to 4.4 branch