Pr/fix cuda warnings #274
Merged
Pr/fix cuda warnings #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brscm2 has been deprecated :'(
10.1 no longer exists on docker hub
Merged
|
This potentially breaks PSC: https://github.com/psc-code/psc/blob/main/src/include/psc_fields_cuda.h#L189 I am not sure how this is working in PSC though - the array version of adapt does a std::copy, which I do not expect to work. I think this could easily be replaced by positional argument version, which I believe is device safe. |
germasch
approved these changes
Aug 30, 2023
The PR I submitted against PSC should fix it, just changes which adapt call it uses to the device safe one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.