Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/cuda solver spsv #275

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Pr/cuda solver spsv #275

merged 3 commits into from
Sep 1, 2023

Conversation

bd4
Copy link
Contributor

@bd4 bd4 commented Aug 9, 2023

Improves sparse solvers for CUDA and HIP backends.

@bd4
Copy link
Contributor Author

bd4 commented Aug 9, 2023

draft because this is built on top of #274

@bd4 bd4 marked this pull request as ready for review August 30, 2023 14:15
- make generic and bsrsm2 in place
- use generic for cuda 12.1+
- for cuda < 12, still use csrsm2
- use SpSV for generic when nrhs == 1 (better performance)
Old csrsm2 backend is still present and can be used by defining
GTENSOR_SOLVER_HIP_CSRSM2
Copy link
Contributor

@germasch germasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Mixed results in testing with generic rocSPARSE API
- Adds cmake option GTENSOR_SOLVER_HIP_SPARSE_GENERIC to enable
  the generic backend for further testing
@bd4 bd4 merged commit 5a1e34f into wdmapp:main Sep 1, 2023
18 checks passed
@bd4 bd4 deleted the pr/cuda-solver-spsv branch September 1, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants