Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Implement read-write GitOps #241

Merged
merged 14 commits into from
Jul 30, 2019
Merged

Implement read-write GitOps #241

merged 14 commits into from
Jul 30, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Jul 29, 2019 •
edited by luxas
Loading

This PR contains a collection of improvements to SyncStorage and GitOps support for it.

  • Event batching using batcher
  • GitOps read-write support (committing and pushing)
  • Send MODIFY events for all existing files when starting Ignite
  • watcher rework for batcher

@luxas luxas self-assigned this Jul 30, 2019
@luxas luxas added this to the v0.5.0 milestone Jul 30, 2019
@luxas luxas added kind/enhancement Categorizes issue or PR as related to improving an existing feature. kind/refactor Categorizes issue or PR as related to refactoring code. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 30, 2019
@luxas luxas changed the title Initial changes for GitOps to support SyncStorage Implement read-write GitOps Jul 30, 2019
luxas
luxas approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shaping up super well 💯 ✨

LGTM

Now we have full-blown GitOps!

@luxas luxas merged commit 0513f86 into weaveworks:master Jul 30, 2019
@twelho
Copy link
Contributor Author

twelho commented Jul 30, 2019

👍

This was referenced Jul 30, 2019
Closed
Closed
@twelho twelho deleted the gitops-syncstorage branch July 30, 2019 13:22
@twelho twelho mentioned this pull request Jul 30, 2019
Merged
@luxas luxas mentioned this pull request Jul 31, 2019
Closed
@luxas luxas added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/enhancement Categorizes issue or PR as related to improving an existing feature. labels Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

Assignees

@luxas luxas

Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/refactor Categorizes issue or PR as related to refactoring code. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@twelho @luxas