Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Actually stop the watcher dispatch thread, better formatting consistency #244

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Actually stop the watcher dispatch thread, better formatting consistency #244

merged 1 commit into from
Jul 30, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Jul 30, 2019

Some fixes for #241.

cc @luxas

@twelho twelho added this to the v0.5.0 milestone Jul 30, 2019
@twelho twelho added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/enhancement Categorizes issue or PR as related to improving an existing feature. labels Jul 30, 2019
luxas
luxas approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@luxas luxas merged commit e5046d6 into weaveworks:master Jul 30, 2019
@twelho twelho deleted the storage-fixes branch July 31, 2019 12:03
@luxas luxas removed the kind/enhancement Categorizes issue or PR as related to improving an existing feature. label Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

Assignees

@luxas luxas

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@twelho @luxas