-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the rate of route recalculation to reduce CPU load #111
Merged
+43
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reference adding the goroutine dumps from various nodes in 175 node cluster running the combined patch #110, #111 https://gist.github.com/murali-reddy/d60850ac2ffa4080b5cbd0ce86f51bde Connection between mesh peers across the cluster are stuck in retrying/pending state Snip of logs related to connection processing between peers 172.20.106.10 <-> 172.20.126.119 on 172.20.106.10
on 172.20.126.119
|
df9348c
to
42dabcd
Compare
This was referenced Oct 9, 2019
Introduce a timer to defer recalculation by up to 100ms. This should help in situations where changes are hapenning very rapidly so the recalculation was continuous.
42dabcd
to
d743780
Compare
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
This is a competing solution to #106.
Introduce a timer to defer recalculation by up to 100ms. This should help in situations where changes are hapening very rapidly so the recalculation was continuous.
Probably we should shut down the ticker when no requests are pending, but this is a first step to see how it behaves.