serialize broadcast topology updates and coalesce updates #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates then coalesce into a single update to gossip Fixes #116
murali-reddy
changed the title
bboreham
reviewed
Sep 24, 2019
|
updated PR as per review comments. PTAL |
bboreham
reviewed
Oct 2, 2019
bboreham
approved these changes
Oct 8, 2019
bboreham
reviewed
Oct 8, 2019
local_peer.go
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| func (peer *localPeer) broadcastPendingTopologyUpdates() { | ||
| peer.router.Routes.recalculate() |
There was a problem hiding this comment.
Because this is async, I think it's unwise to move it here.
I'm not entirely sure it was ever necessary, but left at the original place there is some chance it will happen before the broadcast.
There was a problem hiding this comment.
I'm not entirely sure it was ever necessary
I changed it so to avoid recalculate an every add/delete connection. But considering #111
I reverted to keep original calls to routes.recalculate().
bboreham
suggested changes
Oct 8, 2019
Fixed the UT. Added |
bboreham
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address high topology updates gossip's that can result in certain use-cases.
Fixes #116