Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control icon to top corner of the terminal window #1982

Closed
2opremio opened this issue Nov 4, 2016 · 4 comments
Closed

Add control icon to top corner of the terminal window #1982

2opremio opened this issue Nov 4, 2016 · 4 comments
Assignees
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Milestone

Comments

@2opremio
Copy link
Contributor

2opremio commented Nov 4, 2016

Once you have triggered a control you may not be able to tell what control it was by looking at the terminal window alone.

See for instance: #1979

@2opremio 2opremio added component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer chore Related to fix/refinement/improvement of end user or new/existing developer functionality labels Nov 4, 2016
@2opremio 2opremio added this to the November2016 milestone Nov 4, 2016
@jpellizzari jpellizzari self-assigned this Nov 8, 2016
@jpellizzari
Copy link
Contributor

@2opremio I'm trying to understand the requirement. When a control is activated, there should be an icon on the terminal to indicate what happened, like this?
screen shot 2016-11-08 at 1 18 19 pm
Or maybe:
screen shot 2016-11-08 at 1 18 29 pm

@2opremio
Copy link
Contributor Author

2opremio commented Nov 8, 2016

I am not a designer but I was thinking the second option but with the icon
on the top left corner (instead of the top right corner)

On Nov 8, 2016 22:21, "Jordan Pellizzari" notifications@github.com wrote:

@2opremio https://github.com/2opremio I'm trying to understand the
requirement. When a control is activated, there should be an icon on the
terminal to indicate what happened, like this?
[image: screen shot 2016-11-08 at 1 18 19 pm]
https://cloud.githubusercontent.com/assets/2802257/20117559/03e17e1c-a5b6-11e6-92c2-2d3089f8be66.png
Or maybe:
[image: screen shot 2016-11-08 at 1 18 29 pm]
https://cloud.githubusercontent.com/assets/2802257/20117567/0ac4ab28-a5b6-11e6-8393-8475253badb5.png


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1982 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACQOJIsHTrWWaYcEBGx4aL60agblPmJeks5q8OfFgaJpZM4KpdxB
.

@jpellizzari
Copy link
Contributor

jpellizzari commented Nov 15, 2016

@2opremio Do you think we should represent all of the control statuses, or just the ones related to the terminal (attach and exec)? For example, does showing the 'stop' icon make sense?:
screen shot 2016-11-15 at 2 16 24 pm

@2opremio
Copy link
Contributor Author

2opremio commented Nov 15, 2016

I would say just attach and exec. Happy to answer these questions but I am not the expert. @bowenli @davkal or @pidster are much more knowledgable in UX than I am :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

No branches or pull requests

3 participants