Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table view with scrollbar shifts headers #3158

Closed
rndstr opened this issue May 4, 2018 · 0 comments · Fixed by #3169
Closed

Table view with scrollbar shifts headers #3158

rndstr opened this issue May 4, 2018 · 0 comments · Fixed by #3169
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@rndstr
Copy link
Contributor

rndstr commented May 4, 2018

With scrollbar
scope-table-displacement

Without scrollbar
scope-table-align
@rndstr rndstr added bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels May 4, 2018
@rndstr rndstr mentioned this issue May 11, 2018
Merged
rndstr added a commit that referenced this issue May 11, 2018
@rndstr
Dynamic table header width according to scrollbar
977b3a1 
Sizes the fixed table header of `NodeDetailsTable` width dynamically
depending on the content's scrollbar width. Makes sure the table header
cells align with the table body cells.

This also widens the "Parent PID" cell to make sure the text is not cut
off. Alternatively, could be renamed to "PPID".

Fixes #3158.
rndstr added a commit that referenced this issue May 11, 2018
@rndstr
Dynamic table header width according to scrollbar
3fc7c1e 
Sizes the fixed table header of `NodeDetailsTable` width dynamically
depending on the content's scrollbar width. Makes sure the table header
cells align with the table body cells.

This also widens the "Parent PID" cell to make sure the text is not cut
off. Alternatively, could be renamed to "PPID".

Fixes #3158.
rndstr added a commit that referenced this issue May 11, 2018
@rndstr
Dynamic table header width according to scrollbar
bf09938 
Sizes the fixed table header of `NodeDetailsTable` width dynamically
depending on the content's scrollbar width. Makes sure the table header
cells align with the table body cells.

This also widens the "Parent PID" cell to make sure the text is not cut
off. Alternatively, could be renamed to "PPID".

Fixes #3158.
@rndstr rndstr mentioned this issue May 11, 2018
Merged
rndstr added a commit that referenced this issue May 11, 2018
@rndstr
Dynamic table header width according to scrollbar (#3169)
daccb66 
Sizes the fixed table header of `NodeDetailsTable` width dynamically
depending on the content's scrollbar width. Makes sure the table header
cells align with the table body cells.

This also widens the "Parent PID" cell to make sure the text is not cut
off. Alternatively, could be renamed to "PPID".

Fixes #3158.
lilic pushed a commit to lilic/scope that referenced this issue Jul 25, 2018
@rndstr @lilic
Dynamic table header width according to scrollbar (weaveworks#3169)
1db8be2 
Sizes the fixed table header of `NodeDetailsTable` width dynamically
depending on the content's scrollbar width. Makes sure the table header
cells align with the table body cells.

This also widens the "Parent PID" cell to make sure the text is not cut
off. Alternatively, could be renamed to "PPID".

Fixes weaveworks#3158.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamic table header width according to scrollbar weaveworks/scope
1 participant
@rndstr