-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentence cased text everywhere #3166
Conversation
I think keeping the "by foo" makes sense since it describes the grouping. |
c7be682
to
29cf78c
Compare
LmostlyGTM.
|
@bia IMO the main problem is the table header does not line up with the column content (on osx and linux). And the horizontal padding in the header is 2px vs 4px for the content. Lining the headers up with the columns and increasing the padding to 4px looks good to me. The misalignment appears to be intentional because we don't know how wide the scrollbar is on different OS' so we just pick an avg of 8px. See also #3158 |
977b3a1
to
3fc7c1e
Compare
a0e216b
to
24d8726
Compare
Cool, anyways that looks better. Maybe a little more space between the arrow and 'Processes'? |
Follows Weave Cloud's direction of sentence case on most things.
24d8726
to
68d798f
Compare
* Sentence cased text everywhere Follows Weave Cloud's direction of sentence case on most things. * More space between sorter caret and label * Use full topology name for table header
Follows Weave Cloud's direction of sentence case on most things.